Skip to content

Commit 7d41cd7

Browse files
committed
Rename editor-manual to manual
There is a defined list of of valid origin values for the provenance. This does not include `editor`, so to make sure all values are valid we use `manual` instead. See https://github.com/github/codeql/blob/ac1df4de91438904c86e6e3ce5d01f9e6ba2468a/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll#L221-L229
1 parent dc3966e commit 7d41cd7

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

extensions/ql-vscode/src/data-extensions-editor/modeled-method.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export type Provenance =
1111
// Generated by the dataflow model and manually edited
1212
| "df-manual"
1313
// Entered by the user in the editor manually
14-
| "editor-manual";
14+
| "manual";
1515

1616
export type ModeledMethod = {
1717
type: ModeledMethodType;

extensions/ql-vscode/src/stories/data-extensions-editor/DataExtensionsEditor.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ DataExtensionsEditor.args = {
224224
input: "Argument[this]",
225225
output: "ReturnValue",
226226
kind: "taint",
227-
provenance: "editor-manual",
227+
provenance: "manual",
228228
},
229229
"org.sql2o.Query#executeScalar(Class)": {
230230
type: "neutral",

extensions/ql-vscode/src/stories/data-extensions-editor/MethodRow.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ MethodRow.args = {
5050
input: "Argument[this]",
5151
output: "ReturnValue",
5252
kind: "taint",
53-
provenance: "editor-manual",
53+
provenance: "manual",
5454
},
5555
};

extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,7 @@ export const MethodRow = ({
7171
...modeledMethod,
7272
type: target.value as ModeledMethodType,
7373
provenance:
74-
modeledMethod?.provenance === "df-generated"
75-
? "df-manual"
76-
: "editor-manual",
74+
modeledMethod?.provenance === "df-generated" ? "df-manual" : "manual",
7775
});
7876
},
7977
[onChange, externalApiUsage, modeledMethod, argumentsList],

0 commit comments

Comments
 (0)