Skip to content

Commit 805bb74

Browse files
Include full usage in jumpToUsage message
1 parent 209822e commit 805bb74

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

extensions/ql-vscode/src/common/interface-types.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ import {
1717
} from "../variant-analysis/shared/variant-analysis-filter-sort";
1818
import { ErrorLike } from "../common/errors";
1919
import { DataFlowPaths } from "../variant-analysis/shared/data-flow-paths";
20-
import { ExternalApiUsage } from "../data-extensions-editor/external-api-usage";
20+
import {
21+
ExternalApiUsage,
22+
Usage,
23+
} from "../data-extensions-editor/external-api-usage";
2124
import { ModeledMethod } from "../data-extensions-editor/modeled-method";
2225
import { DataExtensionEditorViewState } from "../data-extensions-editor/shared/view-state";
2326
import { Mode } from "../data-extensions-editor/shared/mode";
@@ -522,7 +525,7 @@ interface SwitchModeMessage {
522525

523526
interface JumpToUsageMessage {
524527
t: "jumpToUsage";
525-
location: ResolvableLocationValue;
528+
usage: Usage;
526529
}
527530

528531
interface OpenDatabaseMessage {

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
153153

154154
break;
155155
case "jumpToUsage":
156-
await this.handleJumpToUsage(msg.location);
156+
await this.handleJumpToUsage(msg.usage);
157157

158158
break;
159159
case "saveModeledMethods":
@@ -230,11 +230,11 @@ export class DataExtensionsEditorView extends AbstractWebview<
230230
});
231231
}
232232

233-
protected async handleJumpToUsage(location: ResolvableLocationValue) {
233+
protected async handleJumpToUsage(usage: Usage) {
234234
if (showModelDetailsView()) {
235235
await this.openModelDetailsView();
236236
} else {
237-
await this.jumpToUsage(location);
237+
await this.jumpToUsage(usage.url);
238238
}
239239
}
240240

extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ function sendJumpToUsageMessage(externalApiUsage: ExternalApiUsage) {
326326
vscode.postMessage({
327327
t: "jumpToUsage",
328328
// In framework mode, the first and only usage is the definition of the method
329-
location: externalApiUsage.usages[0].url,
329+
usage: externalApiUsage.usages[0],
330330
});
331331
}
332332

0 commit comments

Comments
 (0)