Skip to content

Commit 807eb92

Browse files
authored
Merge pull request #2313 from github/charisk/repo-tasks-store-renaming
Repo tasks store renaming
2 parents 7308984 + 86dabae commit 807eb92

File tree

6 files changed

+41
-38
lines changed

6 files changed

+41
-38
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from "./repo-tasks-store";

extensions/ql-vscode/src/variant-analysis/store/repo-task-to-domain-mapper.ts renamed to extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-tasks-domain-mapper.ts

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,22 @@ import {
44
VariantAnalysisRepoStatus,
55
} from "../shared/variant-analysis";
66
import {
7-
VariantAnalysisRepositoryTaskData,
8-
VariantAnalysisRepoStatusData,
9-
} from "./repo-task-data-types";
7+
VariantAnalysisRepositoryTaskDto,
8+
VariantAnalysisRepoStatusDto,
9+
} from "./repo-tasks-dto";
1010

11-
export function mapRepoTaskToDomain(
12-
repoTask: VariantAnalysisRepositoryTaskData,
11+
export function mapRepoTaskToDomainModel(
12+
repoTask: VariantAnalysisRepositoryTaskDto,
1313
): VariantAnalysisRepositoryTask {
1414
return {
1515
repository: {
1616
id: repoTask.repository.id,
1717
fullName: repoTask.repository.fullName,
1818
private: repoTask.repository.private,
1919
},
20-
analysisStatus: mapRepoTaskAnalysisStatusToDomain(repoTask.analysisStatus),
20+
analysisStatus: mapRepoTaskAnalysisStatusToDomainModel(
21+
repoTask.analysisStatus,
22+
),
2123
resultCount: repoTask.resultCount,
2224
artifactSizeInBytes: repoTask.artifactSizeInBytes,
2325
failureMessage: repoTask.failureMessage,
@@ -27,21 +29,21 @@ export function mapRepoTaskToDomain(
2729
};
2830
}
2931

30-
function mapRepoTaskAnalysisStatusToDomain(
31-
analysisStatus: VariantAnalysisRepoStatusData,
32+
function mapRepoTaskAnalysisStatusToDomainModel(
33+
analysisStatus: VariantAnalysisRepoStatusDto,
3234
): VariantAnalysisRepoStatus {
3335
switch (analysisStatus) {
34-
case VariantAnalysisRepoStatusData.Pending:
36+
case VariantAnalysisRepoStatusDto.Pending:
3537
return VariantAnalysisRepoStatus.Pending;
36-
case VariantAnalysisRepoStatusData.InProgress:
38+
case VariantAnalysisRepoStatusDto.InProgress:
3739
return VariantAnalysisRepoStatus.InProgress;
38-
case VariantAnalysisRepoStatusData.Succeeded:
40+
case VariantAnalysisRepoStatusDto.Succeeded:
3941
return VariantAnalysisRepoStatus.Succeeded;
40-
case VariantAnalysisRepoStatusData.Failed:
42+
case VariantAnalysisRepoStatusDto.Failed:
4143
return VariantAnalysisRepoStatus.Failed;
42-
case VariantAnalysisRepoStatusData.Canceled:
44+
case VariantAnalysisRepoStatusDto.Canceled:
4345
return VariantAnalysisRepoStatus.Canceled;
44-
case VariantAnalysisRepoStatusData.TimedOut:
46+
case VariantAnalysisRepoStatusDto.TimedOut:
4547
return VariantAnalysisRepoStatus.TimedOut;
4648
default:
4749
assertNever(analysisStatus);

extensions/ql-vscode/src/variant-analysis/store/repo-task-to-data-mapper.ts renamed to extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-tasks-dto-mapper.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ import {
44
VariantAnalysisRepoStatus,
55
} from "../shared/variant-analysis";
66
import {
7-
VariantAnalysisRepositoryTaskData,
8-
VariantAnalysisRepoStatusData,
9-
} from "./repo-task-data-types";
7+
VariantAnalysisRepositoryTaskDto,
8+
VariantAnalysisRepoStatusDto,
9+
} from "./repo-tasks-dto";
1010

11-
export function mapRepoTaskToData(
11+
export function mapRepoTaskToDto(
1212
repoTask: VariantAnalysisRepositoryTask,
13-
): VariantAnalysisRepositoryTaskData {
13+
): VariantAnalysisRepositoryTaskDto {
1414
return {
1515
repository: {
1616
id: repoTask.repository.id,
1717
fullName: repoTask.repository.fullName,
1818
private: repoTask.repository.private,
1919
},
20-
analysisStatus: mapRepoTaskAnalysisStatusToData(repoTask.analysisStatus),
20+
analysisStatus: mapRepoTaskAnalysisStatusToDto(repoTask.analysisStatus),
2121
resultCount: repoTask.resultCount,
2222
artifactSizeInBytes: repoTask.artifactSizeInBytes,
2323
failureMessage: repoTask.failureMessage,
@@ -27,22 +27,22 @@ export function mapRepoTaskToData(
2727
};
2828
}
2929

30-
function mapRepoTaskAnalysisStatusToData(
30+
function mapRepoTaskAnalysisStatusToDto(
3131
analysisStatus: VariantAnalysisRepoStatus,
32-
): VariantAnalysisRepoStatusData {
32+
): VariantAnalysisRepoStatusDto {
3333
switch (analysisStatus) {
3434
case VariantAnalysisRepoStatus.Pending:
35-
return VariantAnalysisRepoStatusData.Pending;
35+
return VariantAnalysisRepoStatusDto.Pending;
3636
case VariantAnalysisRepoStatus.InProgress:
37-
return VariantAnalysisRepoStatusData.InProgress;
37+
return VariantAnalysisRepoStatusDto.InProgress;
3838
case VariantAnalysisRepoStatus.Succeeded:
39-
return VariantAnalysisRepoStatusData.Succeeded;
39+
return VariantAnalysisRepoStatusDto.Succeeded;
4040
case VariantAnalysisRepoStatus.Failed:
41-
return VariantAnalysisRepoStatusData.Failed;
41+
return VariantAnalysisRepoStatusDto.Failed;
4242
case VariantAnalysisRepoStatus.Canceled:
43-
return VariantAnalysisRepoStatusData.Canceled;
43+
return VariantAnalysisRepoStatusDto.Canceled;
4444
case VariantAnalysisRepoStatus.TimedOut:
45-
return VariantAnalysisRepoStatusData.TimedOut;
45+
return VariantAnalysisRepoStatusDto.TimedOut;
4646
default:
4747
assertNever(analysisStatus);
4848
}

extensions/ql-vscode/src/variant-analysis/store/repo-task-data-types.ts renamed to extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-tasks-dto.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
export interface VariantAnalysisRepositoryTaskData {
2-
repository: RepositoryData;
3-
analysisStatus: VariantAnalysisRepoStatusData;
1+
export interface VariantAnalysisRepositoryTaskDto {
2+
repository: RepositoryDto;
3+
analysisStatus: VariantAnalysisRepoStatusDto;
44
resultCount?: number;
55
artifactSizeInBytes?: number;
66
failureMessage?: string;
@@ -9,13 +9,13 @@ export interface VariantAnalysisRepositoryTaskData {
99
artifactUrl?: string;
1010
}
1111

12-
interface RepositoryData {
12+
interface RepositoryDto {
1313
id: number;
1414
fullName: string;
1515
private: boolean;
1616
}
1717

18-
export enum VariantAnalysisRepoStatusData {
18+
export enum VariantAnalysisRepoStatusDto {
1919
Pending = "pending",
2020
InProgress = "inProgress",
2121
Succeeded = "succeeded",

extensions/ql-vscode/src/variant-analysis/store/repo-task-store.ts renamed to extensions/ql-vscode/src/variant-analysis/repo-tasks-store/repo-tasks-store.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import { outputJson, readJson } from "fs-extra";
22
import { join } from "path";
33
import { VariantAnalysisRepositoryTask } from "../shared/variant-analysis";
4-
import { mapRepoTaskToData } from "./repo-task-to-data-mapper";
5-
import { mapRepoTaskToDomain } from "./repo-task-to-domain-mapper";
4+
import { mapRepoTaskToDto } from "./repo-tasks-dto-mapper";
5+
import { mapRepoTaskToDomainModel } from "./repo-tasks-domain-mapper";
66

77
export const REPO_TASK_FILENAME = "repo_task.json";
88

99
export async function writeRepoTask(
1010
storageDirectory: string,
1111
repoTask: VariantAnalysisRepositoryTask,
1212
): Promise<void> {
13-
const repoTaskData = mapRepoTaskToData(repoTask);
13+
const repoTaskData = mapRepoTaskToDto(repoTask);
1414
await outputJson(join(storageDirectory, REPO_TASK_FILENAME), repoTaskData);
1515
}
1616

@@ -20,5 +20,5 @@ export async function readRepoTask(
2020
const repoTaskData = await readJson(
2121
join(storageDirectory, REPO_TASK_FILENAME),
2222
);
23-
return mapRepoTaskToDomain(repoTaskData);
23+
return mapRepoTaskToDomainModel(repoTaskData);
2424
}

extensions/ql-vscode/src/variant-analysis/variant-analysis-results-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
import { DisposableObject, DisposeHandler } from "../pure/disposable-object";
1818
import { EventEmitter } from "vscode";
1919
import { unzipFile } from "../pure/zip";
20-
import { readRepoTask, writeRepoTask } from "./store/repo-task-store";
20+
import { readRepoTask, writeRepoTask } from "./repo-tasks-store";
2121

2222
type CacheKey = `${number}/${string}`;
2323

0 commit comments

Comments
 (0)