Don't track results manager as a disposable object

elenatanasoiu · elenatanasoiu · commit 8569fa739913 · 2022-10-26T14:36:51.000+01:00
diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts
@@ -52,7 +52,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
     this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx));
     this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this));
 
-    this.variantAnalysisResultsManager = this.push(variantAnalysisResultsManager);
+    this.variantAnalysisResultsManager = variantAnalysisResultsManager;
     this.variantAnalysisResultsManager.onResultLoaded(this.onRepoResultLoaded.bind(this));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA`
`52`	`52`	`this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx));`
`53`	`53`	`this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this));`
`54`	`54`
`55`		`- this.variantAnalysisResultsManager = this.push(variantAnalysisResultsManager);`
	`55`	`+ this.variantAnalysisResultsManager = variantAnalysisResultsManager;`
`56`	`56`	`this.variantAnalysisResultsManager.onResultLoaded(this.onRepoResultLoaded.bind(this));`
`57`	`57`	`}`
`58`	`58`