Skip to content

Commit 868fae0

Browse files
committed
Reorder db language check
1 parent 5f48921 commit 868fae0

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-module.ts

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,14 @@ export class DataExtensionsEditorModule {
7070
return;
7171
}
7272

73-
if (!SUPPORTED_LANGUAGES.includes(db.language)) {
73+
const language = db.language;
74+
if (
75+
!SUPPORTED_LANGUAGES.includes(language) ||
76+
!isQueryLanguage(language)
77+
) {
7478
void showAndLogErrorMessage(
7579
this.app.logger,
76-
`The data extensions editor is not supported for ${db.language} databases.`,
80+
`The data extensions editor is not supported for ${language} databases.`,
7781
);
7882
return;
7983
}
@@ -109,28 +113,19 @@ export class DataExtensionsEditorModule {
109113
return;
110114
}
111115

112-
if (!isQueryLanguage(db.language)) {
113-
void showAndLogExceptionWithTelemetry(
114-
extLogger,
115-
telemetryListener,
116-
redactableError`Unsupported database language ${db.language}`,
117-
);
118-
return;
119-
}
120-
121-
const query = fetchExternalApiQueries[db.language];
116+
const query = fetchExternalApiQueries[language];
122117
if (!query) {
123118
void showAndLogExceptionWithTelemetry(
124119
extLogger,
125120
telemetryListener,
126-
redactableError`No external API usage query found for language ${db.language}`,
121+
redactableError`No external API usage query found for language ${language}`,
127122
);
128123
return;
129124
}
130125

131126
// Create new temporary directory for query files and pack dependencies
132127
const queryDir = (await dir({ unsafeCleanup: true })).path;
133-
await setUpPack(queryDir, query, db.language);
128+
await setUpPack(queryDir, query, language);
134129
await this.cliServer.packInstall(queryDir);
135130

136131
const view = new DataExtensionsEditorView(

0 commit comments

Comments
 (0)