Skip to content

Commit 86d7d83

Browse files
Convert ApiOrMethodCell to ApiOrMethodRow
1 parent a704cd7 commit 86d7d83

1 file changed

Lines changed: 29 additions & 24 deletions

File tree

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ import { ModelInputDropdown } from "./ModelInputDropdown";
2323
import { ModelOutputDropdown } from "./ModelOutputDropdown";
2424
import { ModelEditorViewState } from "../../model-editor/shared/view-state";
2525

26-
const ApiOrMethodCell = styled(VSCodeDataGridCell)`
26+
const ApiOrMethodRow = styled.div`
27+
min-height: calc(var(--input-height) * 1px);
2728
display: flex;
2829
flex-direction: row;
2930
align-items: center;
@@ -112,18 +113,20 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
112113
ref={ref}
113114
focused={revealedMethodSignature === method.signature}
114115
>
115-
<ApiOrMethodCell gridColumn={1}>
116-
<ModelingStatusIndicator status={modelingStatus} />
117-
<MethodClassifications method={method} />
118-
<MethodName {...props.method} />
119-
{viewState.mode === Mode.Application && (
120-
<UsagesButton onClick={jumpToUsage}>
121-
{method.usages.length}
122-
</UsagesButton>
123-
)}
124-
<ViewLink onClick={jumpToUsage}>View</ViewLink>
125-
{props.modelingInProgress && <ProgressRing />}
126-
</ApiOrMethodCell>
116+
<VSCodeDataGridCell gridColumn={1}>
117+
<ApiOrMethodRow>
118+
<ModelingStatusIndicator status={modelingStatus} />
119+
<MethodClassifications method={method} />
120+
<MethodName {...props.method} />
121+
{viewState.mode === Mode.Application && (
122+
<UsagesButton onClick={jumpToUsage}>
123+
{method.usages.length}
124+
</UsagesButton>
125+
)}
126+
<ViewLink onClick={jumpToUsage}>View</ViewLink>
127+
{props.modelingInProgress && <ProgressRing />}
128+
</ApiOrMethodRow>
129+
</VSCodeDataGridCell>
127130
{props.modelingInProgress && (
128131
<>
129132
<VSCodeDataGridCell gridColumn={2}>
@@ -195,17 +198,19 @@ const UnmodelableMethodRow = forwardRef<
195198
ref={ref}
196199
focused={revealedMethodSignature === method.signature}
197200
>
198-
<ApiOrMethodCell gridColumn={1}>
199-
<ModelingStatusIndicator status="saved" />
200-
<MethodName {...props.method} />
201-
{viewState.mode === Mode.Application && (
202-
<UsagesButton onClick={jumpToUsage}>
203-
{method.usages.length}
204-
</UsagesButton>
205-
)}
206-
<ViewLink onClick={jumpToUsage}>View</ViewLink>
207-
<MethodClassifications method={method} />
208-
</ApiOrMethodCell>
201+
<VSCodeDataGridCell gridColumn={1}>
202+
<ApiOrMethodRow>
203+
<ModelingStatusIndicator status="saved" />
204+
<MethodName {...props.method} />
205+
{viewState.mode === Mode.Application && (
206+
<UsagesButton onClick={jumpToUsage}>
207+
{method.usages.length}
208+
</UsagesButton>
209+
)}
210+
<ViewLink onClick={jumpToUsage}>View</ViewLink>
211+
<MethodClassifications method={method} />
212+
</ApiOrMethodRow>
213+
</VSCodeDataGridCell>
209214
<VSCodeDataGridCell gridColumn="span 4">
210215
Method already modeled
211216
</VSCodeDataGridCell>

0 commit comments

Comments
 (0)