Skip to content

Commit 8e2d18d

Browse files
authored
Rename ColumnValue to CellValue (#1196)
1 parent 2c50043 commit 8e2d18d

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

extensions/ql-vscode/src/pure/bqrs-cli-types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ export interface WholeFileLocation {
7979

8080
export type ResolvableLocationValue = WholeFileLocation | LineColumnLocation;
8181

82-
export type UrlValue = ResolvableLocationValue | string;
82+
export type UrlValue = ResolvableLocationValue | string;
8383

84-
export type ColumnValue = EntityValue | number | string | boolean;
84+
export type CellValue = EntityValue | number | string | boolean;
8585

86-
export type ResultRow = ColumnValue[];
86+
export type ResultRow = CellValue[];
8787

8888
export interface RawResultSet {
8989
readonly schema: ResultSetSchema;
@@ -104,6 +104,6 @@ export function transformBqrsResultSet(
104104
}
105105

106106
export interface DecodedBqrsChunk {
107-
tuples: ColumnValue[][];
107+
tuples: CellValue[][];
108108
next?: number;
109109
}

extensions/ql-vscode/src/view/RawTableValue.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import * as React from 'react';
22

33
import { renderLocation } from './result-table-utils';
4-
import { ColumnValue } from '../pure/bqrs-cli-types';
4+
import { CellValue } from '../pure/bqrs-cli-types';
55

66
interface Props {
7-
value: ColumnValue;
7+
value: CellValue;
88
databaseUri: string;
99
}
1010

extensions/ql-vscode/src/vscode-tests/cli-integration/query.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { CancellationTokenSource } from 'vscode-jsonrpc';
88
import * as messages from '../../pure/messages';
99
import * as qsClient from '../../queryserver-client';
1010
import * as cli from '../../cli';
11-
import { ColumnValue } from '../../pure/bqrs-cli-types';
11+
import { CellValue } from '../../pure/bqrs-cli-types';
1212
import { extensions } from 'vscode';
1313
import { CodeQLExtensionInterface } from '../../extension';
1414
import { fail } from 'assert';
@@ -53,7 +53,7 @@ class Checkpoint<T> {
5353
}
5454

5555
type ResultSets = {
56-
[name: string]: ColumnValue[][];
56+
[name: string]: CellValue[][];
5757
}
5858

5959
type QueryTestCase = {

0 commit comments

Comments
 (0)