Skip to content

Commit 90a9753

Browse files
author
Dave Bartolomeo
committed
Merge from master
2 parents edc1f1c + e57a685 commit 90a9753

35 files changed

+1286
-719
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior.
15+
16+
**Expected behavior**
17+
A clear and concise description of what you expected to happen.
18+
19+
**Additional context**
20+
Add any other context about the problem here.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
name: New extension release
3+
about: Create an issue with a checklist for the release steps (write access required
4+
for the steps)
5+
title: Release Checklist for version xx.xx.xx
6+
labels: ''
7+
assignees: ''
8+
9+
---
10+
11+
- [ ] Update this issue title to refer to the version of the release
12+
- [ ] Trigger a release build on Actions by adding a new tag on master of the format `vxx.xx.xx`
13+
- [ ] Monitor the status of the release build in the `Release` workflow in the Actions tab.
14+
- [ ] Download the VSIX from the draft GitHub release that is created when the release build finishes.
15+
- [ ] Log into the [Visual Studio Marketplace](https://marketplace.visualstudio.com/manage/publishers/github).
16+
- [ ] Click the `...` menu in the CodeQL row and click **Update**.
17+
- [ ] Drag the `.vsix` file you downloaded from the GitHub release into the Marketplace and click **Upload**.
18+
- [ ] Publish the draft GitHub release and confirm the new release is marked as the latest release at https://github.com/github/vscode-codeql/releases.

.github/pull_request_template.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<!-- Thank you for submitting a pull request. Please read our pull request guidelines before
2+
submitting your pull request:
3+
https://github.com/github/vscode-codeql/blob/master/CONTRIBUTING.md#submitting-a-pull-request.
4+
-->
5+
6+
Replace this with a description of the changes your pull request makes.
7+
8+
## Checklist
9+
10+
- [ ] [CHANGELOG.md](../extensions/ql-vscode/CHANGELOG.md) has been updated to incorporate all user visible changes made by this pull request.
11+
- [ ] Issues have been created for any UI or other user-facing changes made by this pull request.
12+
- [ ] `@github/product-docs-dsp` has been cc'd in all issues for UI or other user-facing changes made by this pull request.

.github/workflows/main.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ jobs:
1414
with:
1515
fetch-depth: 1
1616

17+
- uses: actions/setup-node@v1
18+
with:
19+
node-version: '10.18.1'
20+
1721
- name: Build
1822
run: |
1923
cd build
@@ -46,6 +50,10 @@ jobs:
4650
with:
4751
fetch-depth: 1
4852

53+
- uses: actions/setup-node@v1
54+
with:
55+
node-version: '10.18.1'
56+
4957
# We have to build the dependencies in `lib` before running any tests.
5058
- name: Build
5159
run: |
@@ -86,4 +94,4 @@ jobs:
8694
if: matrix.os == 'windows-latest'
8795
run: |
8896
cd extensions/ql-vscode
89-
npm run integration
97+
npm run integration

.github/workflows/release.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,16 @@ jobs:
2929
- name: Checkout
3030
uses: actions/checkout@master
3131

32+
- uses: actions/setup-node@v1
33+
with:
34+
node-version: '10.18.1'
35+
36+
# The checkout action does not fetch the master branch.
37+
# Fetch the master branch so that we can base the version bump PR against master.
38+
- name: Fetch master branch
39+
run: |
40+
git fetch --depth=1 origin master:master
41+
3242
- name: Build
3343
run: |
3444
cd build
@@ -47,8 +57,8 @@ jobs:
4757
VSIX_PATH="$(ls dist/*.vsix)"
4858
echo "::set-output name=vsix_path::$VSIX_PATH"
4959
# Transform the GitHub ref so it can be used in a filename.
50-
# This is mainly needed for testing branches that modify this workflow.
51-
REF_NAME="$(echo ${{ github.ref }} | sed -e 's:/:-:g')"
60+
# The last sed invocation is used for testing branches that modify this workflow.
61+
REF_NAME="$(echo ${{ github.ref }} | sed -e 's:^refs/tags/::' | sed -e 's:/:-:g')"
5262
echo "::set-output name=ref_name::$REF_NAME"
5363
5464
# Uploading artifacts is not necessary to create a release.
@@ -100,13 +110,12 @@ jobs:
100110
echo "::set-output name=next_version::$NEXT_VERSION"
101111
102112
- name: Create version bump PR
103-
uses: peter-evans/create-pull-request@7531167f24e3914996c8d5110b5e08478ddadff9 # v1.8.0
113+
uses: peter-evans/create-pull-request@c202684c928d4c9f18394b2ad11df905c5d8b40c # v2.1.2
104114
if: success()
105115
with:
106116
token: ${{ secrets.GITHUB_TOKEN }}
107117
commit-message: Bump version to ${{ steps.bump-patch-version.outputs.next_version }}
108118
title: Bump version to ${{ steps.bump-patch-version.outputs.next_version }}
109119
body: This PR was automatically generated by the GitHub Actions release workflow in this repository.
110120
branch: ${{ format('version/bump-to-{0}', steps.bump-patch-version.outputs.next_version) }}
111-
branch-suffix: none
112121
base: master

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ You can use VS Code to debug the extension without explicitly installing it. Jus
126126
1. Log into the [Visual Studio Marketplace](https://marketplace.visualstudio.com/manage/publishers/github).
127127
1. Click the `...` menu in the CodeQL row and click **Update**.
128128
1. Drag the `.vsix` file you downloaded from the GitHub release into the Marketplace and click **Upload**.
129-
1. Publish the GitHub release.
129+
1. Publish the draft GitHub release and confirm the new release is marked as the latest release at https://github.com/github/vscode-codeql/releases.
130130

131131
## Resources
132132

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ The extension is released. You can download it from the [Visual Studio Marketpla
77
To see what has changed in the last few versions of the extension, see the [Changelog](https://github.com/github/vscode-codeql/blob/master/extensions/ql-vscode/CHANGELOG.md).
88

99
[![CI status badge](https://github.com/github/vscode-codeql/workflows/Build%20Extension/badge.svg)](https://github.com/github/vscode-codeql/actions?query=workflow%3A%22Build+Extension%22+branch%3Amaster)
10+
[![VS Marketplace badge](https://vsmarketplacebadge.apphb.com/version/github.vscode-codeql.svg)](https://marketplace.visualstudio.com/items?itemName=github.vscode-codeql)
1011

1112
## Features
1213

extensions/ql-vscode/CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
# CodeQL for Visual Studio Code: Changelog
22

3-
## 1.0.4
3+
## 1.0.5 - 13 February 2020
4+
5+
- Add an icon next to any failed query runs in the query history
6+
view.
7+
- Add the ability to sort alerts by alert message.
8+
9+
## 1.0.4 - 24 January 2020
10+
11+
- Disable word-based autocomplete by default.
12+
- Add command `CodeQL: Quick Query` for easy query creation without
13+
having to choose a place in the filesystem to store the query file.
414

515
## 1.0.3 - 13 January 2020
616

extensions/ql-vscode/package.json

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "CodeQL for Visual Studio Code",
55
"author": "GitHub",
66
"private": true,
7-
"version": "1.0.4",
7+
"version": "1.0.6",
88
"publisher": "GitHub",
99
"license": "MIT",
1010
"icon": "media/VS-marketplace-CodeQL-icon.png",
@@ -31,6 +31,7 @@
3131
"onCommand:codeQL.setCurrentDatabase",
3232
"onCommand:codeQLDatabases.chooseDatabase",
3333
"onCommand:codeQLDatabases.setCurrentDatabase",
34+
"onCommand:codeQL.quickQuery",
3435
"onWebviewPanel:resultsView",
3536
"onFileSystem:codeql-zip-archive"
3637
],
@@ -43,6 +44,14 @@
4344
"language-configuration.json"
4445
],
4546
"contributes": {
47+
"configurationDefaults": {
48+
"[ql]": {
49+
"editor.wordBasedSuggestions": false
50+
},
51+
"[dbscheme]": {
52+
"editor.wordBasedSuggestions": false
53+
}
54+
},
4655
"languages": [
4756
{
4857
"id": "ql",
@@ -146,6 +155,10 @@
146155
"command": "codeQL.quickEval",
147156
"title": "CodeQL: Quick Evaluation"
148157
},
158+
{
159+
"command": "codeQL.quickQuery",
160+
"title": "CodeQL: Quick Query"
161+
},
149162
{
150163
"command": "codeQL.chooseDatabase",
151164
"title": "CodeQL: Choose Database",
@@ -364,6 +377,7 @@
364377
"classnames": "~2.2.6",
365378
"fs-extra": "^8.1.0",
366379
"glob-promise": "^3.4.0",
380+
"js-yaml": "^3.12.0",
367381
"node-fetch": "~2.6.0",
368382
"react": "^16.8.6",
369383
"react-dom": "^16.8.6",
@@ -386,6 +400,7 @@
386400
"@types/glob": "^7.1.1",
387401
"@types/google-protobuf": "^3.2.7",
388402
"@types/gulp": "^4.0.6",
403+
"@types/js-yaml": "~3.12.1",
389404
"@types/jszip": "~3.1.6",
390405
"@types/mocha": "~5.2.7",
391406
"@types/node": "^12.0.8",

0 commit comments

Comments
 (0)