Skip to content

Commit 911c3af

Browse files
committed
Use a regular const instead of storing this on the class
1 parent f949eda commit 911c3af

2 files changed

Lines changed: 18 additions & 15 deletions

File tree

extensions/ql-vscode/src/skeleton-query-wizard.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,23 @@ type QueryLanguagesToDatabaseMap = {
1515
[id: string]: string;
1616
};
1717

18+
export const QUERY_LANGUAGE_TO_DATABASE_REPO: QueryLanguagesToDatabaseMap = {
19+
cpp: "protocolbuffers/protobuf",
20+
csharp: "dotnet/efcore",
21+
go: "evanw/esbuild",
22+
java: "google/guava",
23+
javascript: "facebook/react",
24+
python: "pallets/flask",
25+
ruby: "rails/rails",
26+
swift: "Alamofire/Alamofire",
27+
};
28+
1829
export class SkeletonQueryWizard {
1930
private language: string | undefined;
2031
private folderName: string | undefined;
2132
private fileName = "example.ql";
2233
private storagePath: string | undefined;
2334

24-
QUERY_LANGUAGE_TO_DATABASE_REPO: QueryLanguagesToDatabaseMap = {
25-
cpp: "protocolbuffers/protobuf",
26-
csharp: "dotnet/efcore",
27-
go: "evanw/esbuild",
28-
java: "google/guava",
29-
javascript: "facebook/react",
30-
python: "pallets/flask",
31-
ruby: "rails/rails",
32-
swift: "Alamofire/Alamofire",
33-
};
34-
3535
constructor(
3636
private readonly cliServer: CodeQLCliServer,
3737
private readonly progress: ProgressCallback,
@@ -206,7 +206,7 @@ export class SkeletonQueryWizard {
206206
maxStep: 3,
207207
});
208208

209-
const githubRepoNwo = this.QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
209+
const githubRepoNwo = QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
210210

211211
await databaseFetcher.downloadGitHubDatabase(
212212
githubRepoNwo,
@@ -229,7 +229,7 @@ export class SkeletonQueryWizard {
229229
throw new Error("Workspace storage path is undefined");
230230
}
231231

232-
const databaseNwo = this.QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
232+
const databaseNwo = QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
233233

234234
const databaseItem = await this.databaseManager.digForDatabaseItem(
235235
this.language,

extensions/ql-vscode/test/vscode-tests/cli-integration/skeleton-query-wizard.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import { CodeQLCliServer } from "../../../src/cli";
2-
import { SkeletonQueryWizard } from "../../../src/skeleton-query-wizard";
2+
import {
3+
QUERY_LANGUAGE_TO_DATABASE_REPO,
4+
SkeletonQueryWizard,
5+
} from "../../../src/skeleton-query-wizard";
36
import { mockedObject, mockedQuickPickItem } from "../utils/mocking.helpers";
47
import * as tmp from "tmp";
58
import { TextDocument, window, workspace, WorkspaceFolder } from "vscode";
@@ -191,7 +194,7 @@ describe("SkeletonQueryWizard", () => {
191194
let databaseItem: DatabaseItem;
192195

193196
beforeEach(async () => {
194-
databaseNwo = wizard.QUERY_LANGUAGE_TO_DATABASE_REPO[chosenLanguage];
197+
databaseNwo = QUERY_LANGUAGE_TO_DATABASE_REPO[chosenLanguage];
195198

196199
databaseItem = {
197200
name: databaseNwo,

0 commit comments

Comments
 (0)