Skip to content

Commit 92ad718

Browse files
committed
Fix data flow path dropdown not updating
1 parent f4a2d85 commit 92ad718

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ const getCodeFlowName = (codeFlow: CodeFlow) => {
1212

1313
type CodeFlowsDropdownProps = {
1414
codeFlows: CodeFlow[];
15+
selectedCodeFlow: CodeFlow;
1516
setSelectedCodeFlow: (value: SetStateAction<CodeFlow>) => void;
1617
};
1718

1819
export const CodeFlowsDropdown = ({
1920
codeFlows,
21+
selectedCodeFlow,
2022
setSelectedCodeFlow,
2123
}: CodeFlowsDropdownProps) => {
2224
const handleChange = useCallback(
@@ -28,13 +30,12 @@ export const CodeFlowsDropdown = ({
2830
[setSelectedCodeFlow, codeFlows],
2931
);
3032

33+
const value = codeFlows
34+
.findIndex((codeFlow) => selectedCodeFlow === codeFlow)
35+
.toString();
36+
3137
return (
32-
<VSCodeDropdown
33-
onChange={
34-
handleChange as ((e: Event) => unknown) &
35-
React.FormEventHandler<HTMLElement>
36-
}
37-
>
38+
<VSCodeDropdown value={value} onChange={handleChange}>
3839
{codeFlows.map((codeFlow, index) => (
3940
<VSCodeOption key={index} value={index.toString()}>
4041
{getCodeFlowName(codeFlow)}

extensions/ql-vscode/src/view/data-flow-paths/DataFlowPaths.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ export const DataFlowPaths = ({
6060
<PathDropdownContainer>
6161
<CodeFlowsDropdown
6262
codeFlows={codeFlows}
63+
selectedCodeFlow={selectedCodeFlow}
6364
setSelectedCodeFlow={setSelectedCodeFlow}
6465
/>
6566
</PathDropdownContainer>

0 commit comments

Comments
 (0)