Change default value of makeSelected from false to true

Author: robertbrignull

extensions/ql-vscode/src/databases/local-databases-ui.ts

@@ -636,13 +636,7 @@ export class DatabaseUI extends DisposableObject {
               this.queryServer?.cliServer,
             );
           } else {
-            const makeSelected = true;
-            await this.databaseManager.openDatabase(
-              progress,
-              token,
-              uri,
-              makeSelected,
-            );
+            await this.databaseManager.openDatabase(progress, token, uri);
           }
         } catch (e) {
           // rethrow and let this be handled by default error handling.
@@ -757,12 +751,10 @@ export class DatabaseUI extends DisposableObject {
         if (byFolder) {
           const fixedUri = await this.fixDbUri(uri);
           // we are selecting a database folder
-          const makeSelected = true;
           return await this.databaseManager.openDatabase(
             progress,
             token,
             fixedUri,
-            makeSelected,
           );
         } else {
           // we are selecting a database archive. Must unzip into a workspace-controlled area

extensions/ql-vscode/src/databases/local-databases.ts

@@ -621,7 +621,7 @@ export class DatabaseManager extends DisposableObject {
     progress: ProgressCallback,
     token: vscode.CancellationToken,
     uri: vscode.Uri,
-    makeSelected = false,
+    makeSelected = true,
     displayName?: string,
     isTutorialDatabase?: boolean,
   ): Promise<DatabaseItem> {

extensions/ql-vscode/src/test-runner.ts

@@ -112,6 +112,7 @@ export class TestRunner extends DisposableObject {
             },
             token,
             uri,
+            false,
           );
           await this.databaseManager.renameDatabaseItem(
             reopenedDatabase,

extensions/ql-vscode/test/vscode-tests/minimal-workspace/local-databases.test.ts

@@ -753,13 +753,10 @@ describe("local databases", () => {
     });
 
     it("should set the database as the currently selected one", async () => {
-      const makeSelected = true;
-
       await databaseManager.openDatabase(
         {} as ProgressCallback,
         {} as CancellationToken,
         mockDbItem.databaseUri,
-        makeSelected,
       );
 
       expect(setCurrentDatabaseItemSpy).toBeCalledTimes(1);