Create query history items at start of test

Author: shati-patel

extensions/ql-vscode/test/pure-tests/query-history-info.test.ts

@@ -8,71 +8,56 @@ import { createMockLocalQueryInfo } from '../../src/vscode-tests/factories/local
 import { createMockRemoteQueryHistoryItem } from '../../src/vscode-tests/factories/remote-queries/remote-query-history-item';
 
 describe('Query history info', () => {
-  describe('getRawQueryName', () => {
-    it('should get the name for local history items', () => {
-      const date = new Date('2022-01-01T00:00:00.000Z');
-      const dateStr = date.toLocaleString();
 
-      const queryHistoryItem = createMockLocalQueryInfo(dateStr);
+  const date = new Date('2022-01-01T00:00:00.000Z');
+  const dateStr = date.toLocaleString();
+  const localQueryHistoryItem = createMockLocalQueryInfo(dateStr);
+  const remoteQueryHistoryItem = createMockRemoteQueryHistoryItem({});
+  const variantAnalysisHistoryItem: VariantAnalysisHistoryItem = {
+    t: 'variant-analysis',
+    status: QueryStatus.InProgress,
+    completed: false,
+    historyItemId: 'abc123',
+    variantAnalysis: createMockVariantAnalysis()
+  };
 
-      const queryName = getRawQueryName(queryHistoryItem);
+  describe('getRawQueryName', () => {
+    it('should get the name for local history items', () => {
+      const queryName = getRawQueryName(localQueryHistoryItem);
 
-      expect(queryName).to.equal(queryHistoryItem.getQueryName());
+      expect(queryName).to.equal(localQueryHistoryItem.getQueryName());
     });
 
     it('should get the name for remote query history items', () => {
-      const queryHistoryItem = createMockRemoteQueryHistoryItem({});
-      const queryName = getRawQueryName(queryHistoryItem);
+      const queryName = getRawQueryName(remoteQueryHistoryItem);
 
-      expect(queryName).to.equal(queryHistoryItem.remoteQuery.queryName);
+      expect(queryName).to.equal(remoteQueryHistoryItem.remoteQuery.queryName);
     });
 
     it('should get the name for variant analysis history items', () => {
-      const queryHistoryItem: VariantAnalysisHistoryItem = {
-        t: 'variant-analysis',
-        status: QueryStatus.InProgress,
-        completed: false,
-        historyItemId: 'abc123',
-        variantAnalysis: createMockVariantAnalysis()
-      };
+      const queryName = getRawQueryName(variantAnalysisHistoryItem);
 
-      const queryName = getRawQueryName(queryHistoryItem);
-
-      expect(queryName).to.equal(queryHistoryItem.variantAnalysis.query.name);
+      expect(queryName).to.equal(variantAnalysisHistoryItem.variantAnalysis.query.name);
     });
   });
 
   describe('getQueryHistoryItemId', () => {
     it('should get the ID for local history items', () => {
-      const date = new Date('2022-01-01T00:00:00.000Z');
-      const dateStr = date.toLocaleString();
-
-      const queryHistoryItem = createMockLocalQueryInfo(dateStr);
+      const historyItemId = getQueryHistoryItemId(localQueryHistoryItem);
 
-      const historyItemId = getQueryHistoryItemId(queryHistoryItem);
-
-      expect(historyItemId).to.equal(queryHistoryItem.initialInfo.id);
+      expect(historyItemId).to.equal(localQueryHistoryItem.initialInfo.id);
     });
 
     it('should get the ID for remote query history items', () => {
-      const queryHistoryItem = createMockRemoteQueryHistoryItem({});
-      const historyItemId = getQueryHistoryItemId(queryHistoryItem);
+      const historyItemId = getQueryHistoryItemId(remoteQueryHistoryItem);
 
-      expect(historyItemId).to.equal(queryHistoryItem.queryId);
+      expect(historyItemId).to.equal(remoteQueryHistoryItem.queryId);
     });
 
     it('should get the ID for variant analysis history items', () => {
-      const queryHistoryItem: VariantAnalysisHistoryItem = {
-        t: 'variant-analysis',
-        status: QueryStatus.InProgress,
-        completed: false,
-        historyItemId: 'abc123',
-        variantAnalysis: createMockVariantAnalysis()
-      };
-
-      const historyItemId = getQueryHistoryItemId(queryHistoryItem);
+      const historyItemId = getQueryHistoryItemId(variantAnalysisHistoryItem);
 
-      expect(historyItemId).to.equal(queryHistoryItem.historyItemId);
+      expect(historyItemId).to.equal(variantAnalysisHistoryItem.historyItemId);
     });
   });
 });