Always trigger pathsChanged listener after initial refresh

Author: robertbrignull

extensions/ql-vscode/src/common/vscode/file-path-discovery.ts

@@ -127,7 +127,8 @@ export abstract class FilePathDiscovery<T extends PathData> extends Discovery {
     });
 
     this.updateWatchers();
-    return this.refresh();
+    await this.refresh();
+    this.onDidChangePathDataEmitter.fire();
   }
 
   private workspaceFoldersChanged(event: WorkspaceFoldersChangeEvent) {

extensions/ql-vscode/test/vscode-tests/minimal-workspace/common/vscode/file-path-discovery.test.ts

@@ -159,6 +159,26 @@ describe("FilePathDiscovery", () => {
         new Set([{ path: join(workspacePath, "1.test"), contents: "1" }]),
       );
     });
+
+    it("should trigger listener when paths are found", async () => {
+      makeTestFile(join(workspacePath, "123.test"));
+
+      const didChangePathsListener = jest.fn();
+      discovery.onDidChangePaths(didChangePathsListener);
+
+      await discovery.initialRefresh();
+
+      expect(didChangePathsListener).toHaveBeenCalled();
+    });
+
+    it("should trigger listener when no paths are found", async () => {
+      const didChangePathsListener = jest.fn();
+      discovery.onDidChangePaths(didChangePathsListener);
+
+      await discovery.initialRefresh();
+
+      expect(didChangePathsListener).toHaveBeenCalled();
+    });
   });
 
   describe("file added", () => {