Skip to content

Commit 9718aa5

Browse files
committed
Rename update Chromium version to generate
This also adds the script as a script in the `package.json` with the naming such that `npm generate` will re-generate the Chromium version file. This will ensure that the CI checks fail when the Chromium version doesn't match the minimum supported VS Code version.
1 parent cce0e14 commit 9718aa5

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

docs/vscode-version.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ This version should be the same as the version of Chromium that is bundled with
3636
the version, run:
3737

3838
```bash
39-
npx ts-node scripts/update-chromium-version.ts
39+
npx ts-node scripts/generate-chromium-version.ts
4040
```
4141

4242
#### Troubleshooting

extensions/ql-vscode/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1902,6 +1902,7 @@
19021902
"lint:scenarios": "ts-node scripts/lint-scenarios.ts",
19031903
"generate": "npm-run-all -p generate:*",
19041904
"generate:schemas": "ts-node scripts/generate-schemas.ts",
1905+
"generate:chromium-version": "ts-node scripts/generate-chromium-version.ts",
19051906
"check-types": "find . -type f -name \"tsconfig.json\" -not -path \"./node_modules/*\" | sed -r 's|/[^/]+$||' | sort | uniq | xargs -I {} sh -c \"echo Checking types in {} && cd {} && npx tsc --noEmit\"",
19061907
"postinstall": "patch-package",
19071908
"prepare": "cd ../.. && husky install"

extensions/ql-vscode/scripts/update-chromium-version.ts renamed to extensions/ql-vscode/scripts/generate-chromium-version.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { getVersionInformation } from "./util/vscode-versions";
55

66
const extensionDirectory = resolve(__dirname, "..");
77

8-
async function updateChromiumVersion() {
8+
async function generateChromiumVersion() {
99
const packageJson = await readJSON(
1010
resolve(extensionDirectory, "package.json"),
1111
);
@@ -36,7 +36,7 @@ async function updateChromiumVersion() {
3636
);
3737
}
3838

39-
updateChromiumVersion().catch((e: unknown) => {
39+
generateChromiumVersion().catch((e: unknown) => {
4040
console.error(e);
4141
process.exit(2);
4242
});

0 commit comments

Comments
 (0)