Merge branch 'main' into robertbrignull/extension_commands

Author: robertbrignull

extensions/ql-vscode/src/common/commands.ts

@@ -5,6 +5,7 @@ import type { DbTreeViewItem } from "../databases/ui/db-tree-view-item";
 import type { DatabaseItem } from "../local-databases";
 import type { QueryHistoryInfo } from "../query-history/query-history-info";
 import type { RepositoriesFilterSortStateWithIds } from "../pure/variant-analysis-filter-sort";
+import type { TestTreeNode } from "../test-tree-node";
 import type {
   VariantAnalysis,
   VariantAnalysisScannedRepository,
@@ -45,6 +46,18 @@ export type BaseCommands = {
   "codeQL.restartQueryServer": () => Promise<void>;
 };
 
+// Commands used when working with queries in the editor
+export type QueryEditorCommands = {
+  "codeQL.openReferencedFile": (selectedQuery: Uri) => Promise<void>;
+  "codeQL.openReferencedFileContextEditor": (
+    selectedQuery: Uri,
+  ) => Promise<void>;
+  "codeQL.openReferencedFileContextExplorer": (
+    selectedQuery: Uri,
+  ) => Promise<void>;
+  "codeQL.previewQueryHelp": (selectedQuery: Uri) => Promise<void>;
+};
+
 // Commands used for running local queries
 export type LocalQueryCommands = {
   "codeQL.runQuery": (uri?: Uri) => Promise<void>;
@@ -211,6 +224,11 @@ export type SummaryLanguageSupportCommands = {
   "codeQL.gotoQL": () => Promise<void>;
 };
 
+export type TestUICommands = {
+  "codeQLTests.showOutputDifferences": (node: TestTreeNode) => Promise<void>;
+  "codeQLTests.acceptOutput": (node: TestTreeNode) => Promise<void>;
+};
+
 export type MockGitHubApiServerCommands = {
   "codeQL.mockGitHubApiServer.startRecording": () => Promise<void>;
   "codeQL.mockGitHubApiServer.saveScenario": () => Promise<void>;
@@ -221,6 +239,8 @@ export type MockGitHubApiServerCommands = {
 
 // All commands where the implementation is provided by this extension.
 export type AllExtensionCommands = BaseCommands &
+  QueryEditorCommands &
+  ResultsViewCommands &
   QueryHistoryCommands &
   LocalDatabasesCommands &
   VariantAnalysisCommands &
@@ -230,6 +250,7 @@ export type AllExtensionCommands = BaseCommands &
   PackagingCommands &
   EvalLogViewerCommands &
   SummaryLanguageSupportCommands &
+  Partial<TestUICommands> &
   MockGitHubApiServerCommands;
 
 export type AllCommands = AllExtensionCommands & BuiltInVsCodeCommands;

extensions/ql-vscode/src/extension.ts

@@ -10,13 +10,12 @@ import {
   Uri,
   version as vscodeVersion,
   window as Window,
-  window,
   workspace,
 } from "vscode";
 import { LanguageClient } from "vscode-languageclient/node";
 import { arch, platform } from "os";
 import { ensureDir } from "fs-extra";
-import { basename, join } from "path";
+import { join } from "path";
 import { dirSync } from "tmp-promise";
 import { testExplorerExtensionId, TestHub } from "vscode-test-adapter-api";
 import { lt, parse } from "semver";
@@ -110,17 +109,18 @@ import { ExtensionApp } from "./common/vscode/vscode-app";
 import { DbModule } from "./databases/db-module";
 import { redactableError } from "./pure/errors";
 import { QueryHistoryDirs } from "./query-history/query-history-dirs";
-import { DirResult } from "tmp";
 import {
   AllExtensionCommands,
   BaseCommands,
   QueryServerCommands,
+  TestUICommands,
 } from "./common/commands";
 import {
   getLocalQueryCommands,
   showResultsForCompletedQuery,
 } from "./local-queries";
 import { getAstCfgCommands } from "./ast-cfg-commands";
+import { getQueryEditorCommands } from "./query-editor";
 
 /**
  * extension.ts
@@ -805,6 +805,7 @@ async function activateWithInstalledDistribution(
   const testExplorerExtension = extensions.getExtension<TestHub>(
     testExplorerExtensionId,
   );
+  let testUiCommands: Partial<TestUICommands> = {};
   if (testExplorerExtension) {
     const testHub = testExplorerExtension.exports;
     const testAdapterFactory = new QLTestAdapterFactory(
@@ -816,6 +817,8 @@ async function activateWithInstalledDistribution(
 
     const testUIService = new TestUIService(testHub);
     ctx.subscriptions.push(testUIService);
+
+    testUiCommands = testUIService.getCommands();
   }
 
   const astViewer = new AstViewer();
@@ -839,6 +842,11 @@ async function activateWithInstalledDistribution(
 
   const allCommands: AllExtensionCommands = {
     ...getCommands(cliServer, qs),
+    ...getQueryEditorCommands({
+      queryRunner: qs,
+      cliServer,
+      qhelpTmpDir: qhelpTmpDir.name,
+    }),
     ...localQueryResultsView.getCommands(),
     ...qhm.getCommands(),
     ...variantAnalysisManager.getCommands(),
@@ -860,6 +868,7 @@ async function activateWithInstalledDistribution(
     }),
     ...evalLogViewer.getCommands(),
     ...summaryLanguageSupport.getCommands(),
+    ...testUiCommands,
     ...mockServer.getCommands(),
   };
 
@@ -887,38 +896,6 @@ async function activateWithInstalledDistribution(
     );
   }
 
-  ctx.subscriptions.push(
-    commandRunner("codeQL.openReferencedFile", async (selectedQuery: Uri) => {
-      await openReferencedFile(qs, cliServer, selectedQuery);
-    }),
-  );
-
-  // Since we are tracking extension usage through commands, this command mirrors the "codeQL.openReferencedFile" command
-  ctx.subscriptions.push(
-    commandRunner(
-      "codeQL.openReferencedFileContextEditor",
-      async (selectedQuery: Uri) => {
-        await openReferencedFile(qs, cliServer, selectedQuery);
-      },
-    ),
-  );
-
-  // Since we are tracking extension usage through commands, this command mirrors the "codeQL.openReferencedFile" command
-  ctx.subscriptions.push(
-    commandRunner(
-      "codeQL.openReferencedFileContextExplorer",
-      async (selectedQuery: Uri) => {
-        await openReferencedFile(qs, cliServer, selectedQuery);
-      },
-    ),
-  );
-
-  ctx.subscriptions.push(
-    commandRunner("codeQL.previewQueryHelp", async (selectedQuery: Uri) => {
-      await previewQueryHelp(app, cliServer, qhelpTmpDir, selectedQuery);
-    }),
-  );
-
   ctx.subscriptions.push(
     commandRunner("codeQL.copyVersion", async () => {
       const text = `CodeQL extension version: ${
@@ -1024,52 +1001,6 @@ async function showResultsForComparison(
   }
 }
 
-async function previewQueryHelp(
-  app: ExtensionApp,
-  cliServer: CodeQLCliServer,
-  qhelpTmpDir: DirResult,
-  selectedQuery: Uri,
-): Promise<void> {
-  // selectedQuery is unpopulated when executing through the command palette
-  const pathToQhelp = selectedQuery
-    ? selectedQuery.fsPath
-    : window.activeTextEditor?.document.uri.fsPath;
-  if (pathToQhelp) {
-    // Create temporary directory
-    const relativePathToMd = `${basename(pathToQhelp, ".qhelp")}.md`;
-    const absolutePathToMd = join(qhelpTmpDir.name, relativePathToMd);
-    const uri = Uri.file(absolutePathToMd);
-    try {
-      await cliServer.generateQueryHelp(pathToQhelp, absolutePathToMd);
-      await app.commands.execute("markdown.showPreviewToSide", uri);
-    } catch (e) {
-      const errorMessage = getErrorMessage(e).includes(
-        "Generating qhelp in markdown",
-      )
-        ? redactableError`Could not generate markdown from ${pathToQhelp}: Bad formatting in .qhelp file.`
-        : redactableError`Could not open a preview of the generated file (${absolutePathToMd}).`;
-      void showAndLogExceptionWithTelemetry(errorMessage, {
-        fullMessage: `${errorMessage}\n${getErrorMessage(e)}`,
-      });
-    }
-  }
-}
-
-async function openReferencedFile(
-  qs: QueryRunner,
-  cliServer: CodeQLCliServer,
-  selectedQuery: Uri,
-): Promise<void> {
-  // If no file is selected, the path of the file in the editor is selected
-  const path =
-    selectedQuery?.fsPath || window.activeTextEditor?.document.uri.fsPath;
-  if (qs !== undefined && path) {
-    const resolved = await cliServer.resolveQlref(path);
-    const uri = Uri.file(resolved.resolvedPath);
-    await window.showTextDocument(uri, { preview: false });
-  }
-}
-
 function addUnhandledRejectionListener() {
   const handler = (error: unknown) => {
     // This listener will be triggered for errors from other extensions as

extensions/ql-vscode/src/packages/commands/CommandManager.ts

@@ -30,7 +30,7 @@ export class CommandManager<
   constructor(
     private readonly commandRegister: <T extends CommandName>(
       commandName: T,
-      fn: Commands[T],
+      fn: NonNullable<Commands[T]>,
     ) => Disposable,
     private readonly commandExecute: <T extends CommandName>(
       commandName: T,
@@ -43,7 +43,7 @@ export class CommandManager<
    */
   register<T extends CommandName>(
     commandName: T,
-    definition: Commands[T],
+    definition: NonNullable<Commands[T]>,
   ): void {
     this.commands.push(this.commandRegister(commandName, definition));
   }

extensions/ql-vscode/src/query-editor.ts

@@ -0,0 +1,79 @@
+import { commands, Uri, window } from "vscode";
+import { CodeQLCliServer } from "./cli";
+import { QueryRunner } from "./queryRunner";
+import { basename, join } from "path";
+import { getErrorMessage } from "./pure/helpers-pure";
+import { redactableError } from "./pure/errors";
+import { showAndLogExceptionWithTelemetry } from "./helpers";
+import { QueryEditorCommands } from "./common/commands";
+
+type QueryEditorOptions = {
+  queryRunner: QueryRunner;
+  cliServer: CodeQLCliServer;
+
+  qhelpTmpDir: string;
+};
+
+export function getQueryEditorCommands({
+  queryRunner,
+  cliServer,
+  qhelpTmpDir,
+}: QueryEditorOptions): QueryEditorCommands {
+  const openReferencedFileCommand = async (selectedQuery: Uri) =>
+    await openReferencedFile(queryRunner, cliServer, selectedQuery);
+
+  return {
+    "codeQL.openReferencedFile": openReferencedFileCommand,
+    // Since we are tracking extension usage through commands, this command mirrors the "codeQL.openReferencedFile" command
+    "codeQL.openReferencedFileContextEditor": openReferencedFileCommand,
+    // Since we are tracking extension usage through commands, this command mirrors the "codeQL.openReferencedFile" command
+    "codeQL.openReferencedFileContextExplorer": openReferencedFileCommand,
+    "codeQL.previewQueryHelp": async (selectedQuery: Uri) =>
+      await previewQueryHelp(cliServer, qhelpTmpDir, selectedQuery),
+  };
+}
+
+async function previewQueryHelp(
+  cliServer: CodeQLCliServer,
+  qhelpTmpDir: string,
+  selectedQuery: Uri,
+): Promise<void> {
+  // selectedQuery is unpopulated when executing through the command palette
+  const pathToQhelp = selectedQuery
+    ? selectedQuery.fsPath
+    : window.activeTextEditor?.document.uri.fsPath;
+  if (pathToQhelp) {
+    // Create temporary directory
+    const relativePathToMd = `${basename(pathToQhelp, ".qhelp")}.md`;
+    const absolutePathToMd = join(qhelpTmpDir, relativePathToMd);
+    const uri = Uri.file(absolutePathToMd);
+    try {
+      await cliServer.generateQueryHelp(pathToQhelp, absolutePathToMd);
+      await commands.executeCommand("markdown.showPreviewToSide", uri);
+    } catch (e) {
+      const errorMessage = getErrorMessage(e).includes(
+        "Generating qhelp in markdown",
+      )
+        ? redactableError`Could not generate markdown from ${pathToQhelp}: Bad formatting in .qhelp file.`
+        : redactableError`Could not open a preview of the generated file (${absolutePathToMd}).`;
+      void showAndLogExceptionWithTelemetry(errorMessage, {
+        fullMessage: `${errorMessage}\n${getErrorMessage(e)}`,
+      });
+    }
+  }
+}
+
+async function openReferencedFile(
+  qs: QueryRunner,
+  cliServer: CodeQLCliServer,
+  selectedQuery: Uri,
+): Promise<void> {
+  // If no file is selected, the path of the file in the editor is selected
+  const path =
+    selectedQuery?.fsPath || window.activeTextEditor?.document.uri.fsPath;
+  if (qs !== undefined && path) {
+    const resolved = await cliServer.resolveQlref(path);
+    const uri = Uri.file(resolved.resolvedPath);
+    await window.showTextDocument(uri, { preview: false });
+  }
+}

extensions/ql-vscode/src/test-ui.ts

@@ -14,9 +14,8 @@ import {
 import { showAndLogWarningMessage } from "./helpers";
 import { TestTreeNode } from "./test-tree-node";
 import { DisposableObject } from "./pure/disposable-object";
-import { UIService } from "./vscode-utils/ui-service";
 import { QLTestAdapter, getExpectedFile, getActualFile } from "./test-adapter";
-import { extLogger } from "./common";
+import { TestUICommands } from "./common/commands";
 
 type VSCodeTestEvent =
   | TestRunStartedEvent
@@ -42,22 +41,23 @@ class QLTestListener extends DisposableObject {
 /**
  * Service that implements all UI and commands for QL tests.
  */
-export class TestUIService extends UIService implements TestController {
+export class TestUIService extends DisposableObject implements TestController {
   private readonly listeners: Map<TestAdapter, QLTestListener> = new Map();
 
   constructor(private readonly testHub: TestHub) {
     super();
 
-    void extLogger.log("Registering CodeQL test panel commands.");
-    this.registerCommand(
-      "codeQLTests.showOutputDifferences",
-      this.showOutputDifferences,
-    );
-    this.registerCommand("codeQLTests.acceptOutput", this.acceptOutput);
-
     testHub.registerTestController(this);
   }
 
+  public getCommands(): TestUICommands {
+    return {
+      "codeQLTests.showOutputDifferences":
+        this.showOutputDifferences.bind(this),
+      "codeQLTests.acceptOutput": this.acceptOutput.bind(this),
+    };
+  }
+
   public dispose(): void {
     this.testHub.unregisterTestController(this);