Fix PR feedback

Dave Bartolomeo · Dave Bartolomeo · commit 99756ae63bcd · 2022-08-12T16:25:52.000-04:00
diff --git a/extensions/ql-vscode/src/log-insights/log-scanner-service.ts b/extensions/ql-vscode/src/log-insights/log-scanner-service.ts
@@ -73,12 +73,14 @@ export class LogScannerService extends DisposableObject {
   ): Promise<void> {
     this.diagnosticCollection.clear();
 
-    if (query?.t !== 'local' || query.jsonEvalLogSummaryLocation === undefined) {
+    if ((query?.t !== 'local')
+      || (query.evalLogSummaryLocation === undefined)
+      || (query.jsonEvalLogSummaryLocation === undefined)) {
       return;
     }
 
     const diagnostics = await this.scanLog(query.jsonEvalLogSummaryLocation, query.evalLogSummarySymbolsLocation);
-    const uri = Uri.file(query.evalLogSummaryLocation!);
+    const uri = Uri.file(query.evalLogSummaryLocation);
     this.diagnosticCollection.set(uri, diagnostics);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -73,12 +73,14 @@ export class LogScannerService extends DisposableObject {`
`73`	`73`	`): Promise<void> {`
`74`	`74`	`this.diagnosticCollection.clear();`
`75`	`75`
`76`		`- if (query?.t !== 'local' \|\| query.jsonEvalLogSummaryLocation === undefined) {`
	`76`	`+ if ((query?.t !== 'local')`
	`77`	`+ \|\| (query.evalLogSummaryLocation === undefined)`
	`78`	`+ \|\| (query.jsonEvalLogSummaryLocation === undefined)) {`
`77`	`79`	`return;`
`78`	`80`	`}`
`79`	`81`
`80`	`82`	`const diagnostics = await this.scanLog(query.jsonEvalLogSummaryLocation, query.evalLogSummarySymbolsLocation);`
`81`		`- const uri = Uri.file(query.evalLogSummaryLocation!);`
	`83`	`+ const uri = Uri.file(query.evalLogSummaryLocation);`
`82`	`84`	`this.diagnosticCollection.set(uri, diagnostics);`
`83`	`85`	`}`
`84`	`86`