Skip to content

Commit 9c51974

Browse files
authored
Merge pull request #1821 from github/koesie10/monitor-error-handling
Handle errors when retrieving variant analyses in the monitor
2 parents 6d1b5ab + 3d81e1b commit 9c51974

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,12 @@ import {
1313
VariantAnalysis,
1414
VariantAnalysisScannedRepository,
1515
} from "./shared/variant-analysis";
16+
import { VariantAnalysis as ApiVariantAnalysis } from "./gh-api/variant-analysis";
1617
import { processUpdatedVariantAnalysis } from "./variant-analysis-processor";
1718
import { DisposableObject } from "../pure/disposable-object";
1819
import { sleep } from "../pure/time";
20+
import { getErrorMessage } from "../pure/helpers-pure";
21+
import { showAndLogWarningMessage } from "../helpers";
1922

2023
export class VariantAnalysisMonitor extends DisposableObject {
2124
// With a sleep of 5 seconds, the maximum number of attempts takes
@@ -60,11 +63,19 @@ export class VariantAnalysisMonitor extends DisposableObject {
6063
return;
6164
}
6265

63-
const variantAnalysisSummary = await getVariantAnalysis(
64-
credentials,
65-
variantAnalysis.controllerRepo.id,
66-
variantAnalysis.id,
67-
);
66+
let variantAnalysisSummary: ApiVariantAnalysis;
67+
try {
68+
variantAnalysisSummary = await getVariantAnalysis(
69+
credentials,
70+
variantAnalysis.controllerRepo.id,
71+
variantAnalysis.id,
72+
);
73+
} catch (e) {
74+
void showAndLogWarningMessage(
75+
`Error while monitoring variant analysis: ${getErrorMessage(e)}`,
76+
);
77+
continue;
78+
}
6879

6980
variantAnalysis = processUpdatedVariantAnalysis(
7081
variantAnalysis,

0 commit comments

Comments
 (0)