Skip to content

Commit 9f3baad

Browse files
committed
Rename getResults to readQueryResults
1 parent 0b1b03d commit 9f3baad

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { ResolvableLocationValue } from "../pure/bqrs-cli-types";
2727
import { showResolvableLocation } from "../interface-utils";
2828
import { decodeBqrsToExternalApiUsages } from "./bqrs";
2929
import { redactableError } from "../pure/errors";
30-
import { getResults, runQuery } from "./external-api-usage-query";
30+
import { readQueryResults, runQuery } from "./external-api-usage-query";
3131
import { createDataExtensionYaml, loadDataExtensionYaml } from "./yaml";
3232
import { ExternalApiUsage } from "./external-api-usage";
3333
import { ModeledMethod } from "./modeled-method";
@@ -192,7 +192,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
192192
maxStep: 1500,
193193
});
194194

195-
const bqrsChunk = await getResults({
195+
const bqrsChunk = await readQueryResults({
196196
cliServer: this.cliServer,
197197
bqrsPath: queryResult.outputDir.bqrsPath,
198198
logger: extLogger,

extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export type GetResultsOptions = {
9090
logger: Logger;
9191
};
9292

93-
export async function getResults({
93+
export async function readQueryResults({
9494
cliServer,
9595
bqrsPath,
9696
logger,

extensions/ql-vscode/test/vscode-tests/no-workspace/data-extensions-editor/external-api-usage-query.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {
2-
getResults,
2+
readQueryResults,
33
runQuery,
44
} from "../../../../src/data-extensions-editor/external-api-usage-query";
55
import { createMockLogger } from "../../../__mocks__/loggerMock";
@@ -135,7 +135,7 @@ describe("getResults", () => {
135135
"result-sets": [],
136136
});
137137

138-
expect(await getResults(options)).toBeUndefined();
138+
expect(await readQueryResults(options)).toBeUndefined();
139139
expect(options.logger.log).toHaveBeenCalledWith(
140140
expect.stringMatching(/Expected exactly one result set/),
141141
);
@@ -165,7 +165,7 @@ describe("getResults", () => {
165165
],
166166
});
167167

168-
expect(await getResults(options)).toBeUndefined();
168+
expect(await readQueryResults(options)).toBeUndefined();
169169
expect(options.logger.log).toHaveBeenCalledWith(
170170
expect.stringMatching(/Expected exactly one result set/),
171171
);
@@ -211,7 +211,7 @@ describe("getResults", () => {
211211
};
212212
options.cliServer.bqrsDecode.mockResolvedValue(decodedResultSet);
213213

214-
const result = await getResults(options);
214+
const result = await readQueryResults(options);
215215
expect(result).toEqual(decodedResultSet);
216216
expect(options.cliServer.bqrsInfo).toHaveBeenCalledWith(options.bqrsPath);
217217
expect(options.cliServer.bqrsDecode).toHaveBeenCalledWith(

0 commit comments

Comments
 (0)