Skip to content

Commit a68d5df

Browse files
Apply suggestions from code review
1 parent 495f632 commit a68d5df

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/node-version.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ You can find this info by seleting "About Visual Studio Code" from the top menu.
1414
## Updating the Node.js version
1515

1616
The following files will need to be updated:
17+
1718
- `.github/workflows/cli-test.yml` - the "node-version: '[VERSION]'" setting
1819
- `.github/workflows/main.yml` - all the "node-version: '[VERSION]'" settings
1920
- `.github/workflows/release.yml` - the "node-version: '[VERSION]'" setting

docs/vscode-version.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ The CodeQL for VS Code extension specifies the versions of VS Code that it is co
1616

1717
Generally we should aim to support as wide a range of VS Code versions as we can, so unless there is a reason to do so we do not update the minimum VS Code version requirement.
1818
Reasons for updating the minimum VS Code version include:
19+
1920
- A new feature is included in VS Code. We may want to ensure that it is available to use so we do not have to provide an alternative code path.
2021
- A breaking change has happened in VS Code, and it is not possible to support both new and old versions.
2122

@@ -27,6 +28,6 @@ To provide a good experience to users, it is recommented to update the `MIN_VERS
2728

2829
## VS Code version used in tests
2930

30-
Our integration tests are currently pinned to use an older version of VS Code due to https://github.com/github/vscode-codeql/issues/2402.
31+
Our integration tests are currently pinned to use an older version of VS Code due to <https://github.com/github/vscode-codeql/issues/2402>.
3132
This version is specified in [`jest-runner-vscode.config.base.js`](https://github.com/github/vscode-codeql/blob/d93f2b67c84e79737b0ce4bb74e31558b5f5166e/extensions/ql-vscode/test/vscode-tests/jest-runner-vscode.config.base.js#L17).
3233
Until this is resolved this will limit us updating our minimum supported version of VS Code.

0 commit comments

Comments
 (0)