Compare against title property

aeisenberg · jcreedcmu · aeisenberg · commit a6ed6748165e · 2020-06-15T12:22:01.000-07:00
Co-authored-by: jcreedcmu &lt;jcreed@gmail.com&gt;
diff --git a/extensions/ql-vscode/src/helpers.ts b/extensions/ql-vscode/src/helpers.ts
@@ -118,7 +118,7 @@ export async function showBinaryChoiceDialog(message: string): Promise<boolean>
   const yesItem = { title: 'Yes', isCloseAffordance: false };
   const noItem = { title: 'No', isCloseAffordance: true };
   const chosenItem = await Window.showInformationMessage(message, { modal: true }, yesItem, noItem);
-  return chosenItem?.title === 'Yes';
+  return chosenItem?.title === yesItem.title;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ export async function showBinaryChoiceDialog(message: string): Promise<boolean>`
`118`	`118`	`const yesItem = { title: 'Yes', isCloseAffordance: false };`
`119`	`119`	`const noItem = { title: 'No', isCloseAffordance: true };`
`120`	`120`	`const chosenItem = await Window.showInformationMessage(message, { modal: true }, yesItem, noItem);`
`121`		`- return chosenItem?.title === 'Yes';`
	`121`	`+ return chosenItem?.title === yesItem.title;`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`/**`