Throw from getModelsAsDataLanguage

Author: koesie10

extensions/ql-vscode/src/model-editor/flow-model-queries.ts

@@ -144,9 +144,6 @@ async function runSingleFlowQuery(
 
   // Interpret the results
   const modelsAsDataLanguage = getModelsAsDataLanguage(language);
-  if (!modelsAsDataLanguage) {
-    throw new Error(`No models-as-data definition for ${language}`);
-  }
 
   const definition = modelsAsDataLanguage[type];
 

extensions/ql-vscode/src/model-editor/languages/languages.ts

@@ -9,6 +9,10 @@ const languages: Partial<Record<QueryLanguage, ModelsAsDataLanguage>> = {
 
 export function getModelsAsDataLanguage(
   language: QueryLanguage,
-): ModelsAsDataLanguage | undefined {
-  return languages[language];
+): ModelsAsDataLanguage {
+  const definition = languages[language];
+  if (!definition) {
+    throw new Error(`No models-as-data definition for ${language}`);
+  }
+  return definition;
 }

extensions/ql-vscode/src/model-editor/yaml.ts

@@ -39,9 +39,6 @@ export function createDataExtensionYaml(
   modeledMethods: readonly ModeledMethod[],
 ) {
   const modelsAsDataLanguage = getModelsAsDataLanguage(language);
-  if (!modelsAsDataLanguage) {
-    throw new Error(`No models as data language for ${language}`);
-  }
 
   const methodsByType: Record<
     Exclude<ModeledMethodType, "none">,
@@ -253,9 +250,6 @@ export function loadDataExtensionYaml(
   }
 
   const modelsAsDataLanguage = getModelsAsDataLanguage(language);
-  if (!modelsAsDataLanguage) {
-    throw new Error(`No models as data language for ${language}`);
-  }
 
   const extensions = data.extensions;
 

extensions/ql-vscode/src/view/model-editor/ModelKindDropdown.tsx

@@ -24,9 +24,6 @@ export const ModelKindDropdown = ({
 }: Props) => {
   const predicate = useMemo(() => {
     const modelsAsDataLanguage = getModelsAsDataLanguage(language);
-    if (!modelsAsDataLanguage) {
-      throw new Error(`No models for language ${language}`);
-    }
 
     return modeledMethod?.type && modeledMethod.type !== "none"
       ? modelsAsDataLanguage[modeledMethod.type]