Enable eqeqeq ESLint rule and fix violations (#2043)

Author: charisk

extensions/ql-vscode/.eslintrc.js

@@ -49,7 +49,6 @@ const baseConfig = {
     "@typescript-eslint/no-throw-literal": "error",
     "no-useless-escape": 0,
     camelcase: "off",
-    eqeqeq: "off",
     "escompat/no-regexp-lookbehind": "off",
     "etc/no-implicit-any-catch": "error",
     "filenames/match-regex": "off",

extensions/ql-vscode/src/abstract-webview.ts

@@ -51,7 +51,7 @@ export abstract class AbstractWebview<
   }
 
   protected async getPanel(): Promise<WebviewPanel> {
-    if (this.panel == undefined) {
+    if (this.panel === undefined) {
       const { ctx } = this;
 
       // This is an async method, so in theory this method can be called concurrently. To ensure that we don't

extensions/ql-vscode/src/cli.ts

@@ -384,7 +384,7 @@ export class CodeQLCliServer implements Disposable {
         this.killProcessIfRunning();
         // Report the error (if there is a stderr then use that otherwise just report the error cod or nodejs error)
         const newError =
-          stderrBuffers.length == 0
+          stderrBuffers.length === 0
             ? new Error(`${description} failed: ${err}`)
             : new Error(
                 `${description} failed: ${Buffer.concat(stderrBuffers).toString(

extensions/ql-vscode/src/config.ts

@@ -357,7 +357,7 @@ export class QueryServerConfigListener
     if (memory === null) {
       return undefined;
     }
-    if (memory == 0 || typeof memory !== "number") {
+    if (memory === 0 || typeof memory !== "number") {
       void extLogger.log(
         `Ignoring value '${memory}' for setting ${MEMORY_SETTING.qualifiedName}`,
       );

extensions/ql-vscode/src/contextual/locationFinder.ts

@@ -128,9 +128,9 @@ function createTemplates(path: string): Record<string, string> {
 function isValidSelect(selectInfo: ResultSetSchema | undefined) {
   return (
     selectInfo &&
-    selectInfo.columns.length == 3 &&
-    selectInfo.columns[0].kind == ColumnKindCode.ENTITY &&
-    selectInfo.columns[1].kind == ColumnKindCode.ENTITY &&
-    selectInfo.columns[2].kind == ColumnKindCode.STRING
+    selectInfo.columns.length === 3 &&
+    selectInfo.columns[0].kind === ColumnKindCode.ENTITY &&
+    selectInfo.columns[1].kind === ColumnKindCode.ENTITY &&
+    selectInfo.columns[2].kind === ColumnKindCode.STRING
   );
 }

extensions/ql-vscode/src/databases.ts

@@ -903,7 +903,7 @@ export class DatabaseManager extends DisposableObject {
     token: vscode.CancellationToken,
     item: DatabaseItem,
   ) {
-    if (this._currentDatabaseItem == item) {
+    if (this._currentDatabaseItem === item) {
       this._currentDatabaseItem = undefined;
     }
     const index = this.databaseItems.findIndex(

extensions/ql-vscode/src/distribution.ts

@@ -650,10 +650,10 @@ export class ReleasesApiConsumer {
       redirectCount < ReleasesApiConsumer._maxRedirects
     ) {
       const parsedRedirectUrl = parse(redirectUrl);
-      if (parsedRedirectUrl.protocol != "https:") {
+      if (parsedRedirectUrl.protocol !== "https:") {
         throw new Error("Encountered a non-https redirect, rejecting");
       }
-      if (parsedRedirectUrl.host != "api.github.com") {
+      if (parsedRedirectUrl.host !== "api.github.com") {
         // Remove authorization header if we are redirected outside of the GitHub API.
         //
         // This is necessary to stream release assets since AWS fails if more than one auth

extensions/ql-vscode/src/interface.ts

@@ -110,7 +110,7 @@ function sortInterpretedResults(
 function interpretedPageSize(
   interpretation: Interpretation | undefined,
 ): number {
-  if (interpretation?.data.t == "GraphInterpretationData") {
+  if (interpretation?.data.t === "GraphInterpretationData") {
     // Graph views always have one result per page.
     return 1;
   }
@@ -124,7 +124,7 @@ function numPagesOfResultSet(
   const pageSize = interpretedPageSize(interpretation);
 
   const n =
-    interpretation?.data.t == "GraphInterpretationData"
+    interpretation?.data.t === "GraphInterpretationData"
       ? interpretation.data.dot.length
       : resultSet.schema.rows;
 
@@ -141,7 +141,7 @@ function numInterpretedPages(
   const pageSize = interpretedPageSize(interpretation);
 
   const n =
-    interpretation.data.t == "GraphInterpretationData"
+    interpretation.data.t === "GraphInterpretationData"
       ? interpretation.data.dot.length
       : interpretation.data.runs[0].results?.length || 0;
 
@@ -446,7 +446,7 @@ export class ResultsView extends AbstractWebview<
 
     const selectedTable = getDefaultResultSetName(resultSetNames);
     const schema = resultSetSchemas.find(
-      (resultSet) => resultSet.name == selectedTable,
+      (resultSet) => resultSet.name === selectedTable,
     )!;
 
     // Use sorted results path if it exists. This may happen if we are
@@ -590,7 +590,7 @@ export class ResultsView extends AbstractWebview<
     const resultSetNames = allResultSetSchemas.map((schema) => schema.name);
 
     const schema = resultSetSchemas.find(
-      (resultSet) => resultSet.name == selectedTable,
+      (resultSet) => resultSet.name === selectedTable,
     )!;
     if (schema === undefined)
       throw new Error(`Query result set '${selectedTable}' not found.`);

extensions/ql-vscode/src/legacy-query-server/run-queries.ts

@@ -321,7 +321,7 @@ export async function compileAndRunQueryAgainstDatabase(
   // This test will produce confusing results if we ever change the name of the database schema files.
   const querySchemaName = basename(packConfig.dbscheme);
   const dbSchemaName = basename(dbItem.contents.dbSchemeUri.fsPath);
-  if (querySchemaName != dbSchemaName) {
+  if (querySchemaName !== dbSchemaName) {
     void extLogger.log(
       `Query schema was ${querySchemaName}, but database schema was ${dbSchemaName}.`,
     );
@@ -403,7 +403,7 @@ export async function compileAndRunQueryAgainstDatabase(
     } catch (e) {
       if (
         e instanceof ResponseError &&
-        e.code == LSPErrorCodes.RequestCancelled
+        e.code === LSPErrorCodes.RequestCancelled
       ) {
         return createSyntheticResult(query, "Query cancelled");
       } else {
@@ -432,7 +432,7 @@ export async function compileAndRunQueryAgainstDatabase(
         query: query.queryEvalInfo,
         message,
         result,
-        successful: result.resultType == messages.QueryResultType.SUCCESS,
+        successful: result.resultType === messages.QueryResultType.SUCCESS,
         logFileLocation: result.logFileLocation,
         dispose: () => {
           qs.logger.removeAdditionalLogLocation(result.logFileLocation);

extensions/ql-vscode/src/log-insights/join-order.ts

@@ -338,7 +338,7 @@ class JoinOrderScanner implements EvaluationLogScanner {
           inLayerEvent.predicateIterationMillis.length <= iteration
             ? -1
             : inLayerEvent.predicateIterationMillis[iteration];
-        if (iterationTime != -1) {
+        if (iterationTime !== -1) {
           const run: PipelineRun =
             inLayerEvent.pipelineRuns[nextPipeline[predicate]++];
           func(inLayerEvent, run, iteration);