Skip to content

Commit aad1fee

Browse files
Stop mocking sendTelemetryException because we don't use that anywhere in the program
1 parent 48399a9 commit aad1fee

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

extensions/ql-vscode/test/vscode-tests/no-workspace/telemetry.test.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ describe("telemetry reporting", () => {
3030
let sendTelemetryEventSpy: jest.SpiedFunction<
3131
typeof TelemetryReporter.prototype.sendTelemetryEvent
3232
>;
33-
let sendTelemetryExceptionSpy: jest.SpiedFunction<
34-
typeof TelemetryReporter.prototype.sendTelemetryException
35-
>;
3633
let disposeSpy: jest.SpiedFunction<
3734
typeof TelemetryReporter.prototype.dispose
3835
>;
@@ -56,9 +53,6 @@ describe("telemetry reporting", () => {
5653
sendTelemetryEventSpy = jest
5754
.spyOn(TelemetryReporter.prototype, "sendTelemetryEvent")
5855
.mockReturnValue(undefined);
59-
sendTelemetryExceptionSpy = jest
60-
.spyOn(TelemetryReporter.prototype, "sendTelemetryException")
61-
.mockReturnValue(undefined);
6256
disposeSpy = jest
6357
.spyOn(TelemetryReporter.prototype, "dispose")
6458
.mockResolvedValue(undefined);
@@ -198,8 +192,6 @@ describe("telemetry reporting", () => {
198192
},
199193
{ executionTime: 1234 },
200194
);
201-
202-
expect(sendTelemetryExceptionSpy).not.toBeCalled();
203195
});
204196

205197
it("should send a command usage event with an error", async () => {
@@ -221,8 +213,6 @@ describe("telemetry reporting", () => {
221213
},
222214
{ executionTime: 1234 },
223215
);
224-
225-
expect(sendTelemetryExceptionSpy).not.toBeCalled();
226216
});
227217

228218
it("should send a command usage event with a cli version", async () => {
@@ -246,8 +236,6 @@ describe("telemetry reporting", () => {
246236
{ executionTime: 1234 },
247237
);
248238

249-
expect(sendTelemetryExceptionSpy).not.toBeCalled();
250-
251239
// Verify that if the cli version is not set, then the telemetry falls back to "not-set"
252240
sendTelemetryEventSpy.mockClear();
253241
telemetryListener.cliVersion = undefined;
@@ -278,7 +266,6 @@ describe("telemetry reporting", () => {
278266
telemetryListener.sendCommandUsage("command-id", 1234, new Error());
279267

280268
expect(sendTelemetryEventSpy).not.toBeCalled();
281-
expect(sendTelemetryExceptionSpy).not.toBeCalled();
282269
});
283270

284271
it("should send an event when telemetry is re-enabled", async () => {

0 commit comments

Comments
 (0)