Skip to content

Commit abbc130

Browse files
committed
Use new type in dbSchemeToLanguage
1 parent 9508b62 commit abbc130

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

extensions/ql-vscode/src/cli.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ import { QueryMetadata, SortDirection } from "./pure/interface-types";
2626
import { Logger, ProgressReporter } from "./common";
2727
import { CompilationMessage } from "./pure/legacy-messages";
2828
import { sarifParser } from "./sarif-parser";
29-
import { dbSchemeToLanguage, walkDirectory } from "./helpers";
29+
import { walkDirectory } from "./helpers";
3030
import { App } from "./common/app";
31-
import { QueryLanguage } from "./qlpack-generator";
31+
import { QueryLanguage } from "./types/query-language";
3232

3333
/**
3434
* The version of the SARIF format that we are using.
@@ -1179,9 +1179,11 @@ export class CodeQLCliServer implements Disposable {
11791179
*/
11801180
public async getSupportedLanguages(): Promise<string[]> {
11811181
if (!this._supportedLanguages) {
1182-
// Get the intersection of resolveLanguages with the list of hardcoded languages in dbSchemeToLanguage.
1182+
// Get the intersection of resolveLanguages with the list of languages in QueryLanguage.
11831183
const resolvedLanguages = Object.keys(await this.resolveLanguages());
1184-
const hardcodedLanguages = Object.values(dbSchemeToLanguage);
1184+
const hardcodedLanguages = Object.values(QueryLanguage).map((s) =>
1185+
s.toString(),
1186+
);
11851187

11861188
this._supportedLanguages = resolvedLanguages.filter((lang) =>
11871189
hardcodedLanguages.includes(lang),

extensions/ql-vscode/test/vscode-tests/no-workspace/helpers.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import {
3030
walkDirectory,
3131
} from "../../../src/helpers";
3232
import { reportStreamProgress } from "../../../src/commandRunner";
33+
import { QueryLanguage } from "../../../src/types/query-language";
3334

3435
describe("helpers", () => {
3536
describe("Invocation rate limiter", () => {
@@ -146,10 +147,14 @@ describe("helpers", () => {
146147

147148
describe("codeql-database.yml tests", () => {
148149
let dir: tmp.DirResult;
150+
let language: QueryLanguage;
151+
149152
beforeEach(() => {
150153
dir = tmp.dirSync();
154+
language = QueryLanguage.Cpp;
155+
151156
const contents = dump({
152-
primaryLanguage: "cpp",
157+
primaryLanguage: language,
153158
});
154159
writeFileSync(join(dir.name, "codeql-database.yml"), contents, "utf8");
155160
});
@@ -159,7 +164,7 @@ describe("helpers", () => {
159164
});
160165

161166
it("should get initial query contents when language is known", () => {
162-
expect(getInitialQueryContents("cpp", "hucairz")).toBe(
167+
expect(getInitialQueryContents(language, "hucairz")).toBe(
163168
'import cpp\n\nselect ""',
164169
);
165170
});

0 commit comments

Comments
 (0)