Convert the codeQL.loadVariantAnalysisRepoResults command

Author: robertbrignull

extensions/ql-vscode/src/common/commands.ts

@@ -6,6 +6,7 @@ import { RepositoriesFilterSortStateWithIds } from "../pure/variant-analysis-fil
 import {
   VariantAnalysis,
   VariantAnalysisScannedRepository,
+  VariantAnalysisScannedRepositoryResult,
 } from "../variant-analysis/shared/variant-analysis";
 
 // A command function matching the signature that VS Code calls when
@@ -75,6 +76,10 @@ export type VariantAnalysisCommands = {
     variantAnalysisId: number,
     filterSort?: RepositoriesFilterSortStateWithIds,
   ) => Promise<void>;
+  "codeQL.loadVariantAnalysisRepoResults": (
+    variantAnalysisId: number,
+    repositoryFullName: string,
+  ) => Promise<VariantAnalysisScannedRepositoryResult>;
   "codeQL.monitorVariantAnalysis": (
     variantAnalysis: VariantAnalysis,
   ) => Promise<void>;

extensions/ql-vscode/src/extension.ts

@@ -125,7 +125,6 @@ import { createVariantAnalysisContentProvider } from "./variant-analysis/variant
 import { VSCodeMockGitHubApiServer } from "./mocks/vscode-mock-gh-api-server";
 import { VariantAnalysisResultsManager } from "./variant-analysis/variant-analysis-results-manager";
 import { ExtensionApp } from "./common/vscode/vscode-app";
-import { RepositoriesFilterSortStateWithIds } from "./pure/variant-analysis-filter-sort";
 import { DbModule } from "./databases/db-module";
 import { redactableError } from "./pure/errors";
 import { QueryHistoryDirs } from "./query-history/query-history-dirs";
@@ -1102,18 +1101,6 @@ async function activateWithInstalledDistribution(
     }),
   );
 
-  ctx.subscriptions.push(
-    commandRunner(
-      "codeQL.loadVariantAnalysisRepoResults",
-      async (variantAnalysisId: number, repositoryFullName: string) => {
-        await variantAnalysisManager.loadResults(
-          variantAnalysisId,
-          repositoryFullName,
-        );
-      },
-    ),
-  );
-
   // The "openVariantAnalysisView" command is internal-only.
   ctx.subscriptions.push(
     commandRunner(

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

@@ -135,6 +135,7 @@ export class VariantAnalysisManager
         this.enqueueDownload.bind(this),
       "codeQL.copyVariantAnalysisRepoList":
         this.copyRepoListToClipboard.bind(this),
+      "codeQL.loadVariantAnalysisRepoResults": this.loadResults.bind(this),
       "codeQL.monitorVariantAnalysis": this.monitorVariantAnalysis.bind(this),
       "codeQL.openVariantAnalysisLogs": this.openVariantAnalysisLogs.bind(this),
       "codeQL.runVariantAnalysis":