db-manager: remove tests and functionality

Author: norascheuch

extensions/ql-vscode/src/databases/db-item.ts

@@ -13,11 +13,6 @@ export enum DbItemKind {
   RemoteRepo = "RemoteRepo",
 }
 
-export enum DbListKind {
-  Local = "Local",
-  Remote = "Remote",
-}
-
 export interface RootLocalDbItem {
   kind: DbItemKind.RootLocal;
   expanded: boolean;
@@ -108,16 +103,6 @@ export function isRemoteRepoDbItem(dbItem: DbItem): dbItem is RemoteRepoDbItem {
   return dbItem.kind === DbItemKind.RemoteRepo;
 }
 
-export function isLocalListDbItem(dbItem: DbItem): dbItem is LocalListDbItem {
-  return dbItem.kind === DbItemKind.LocalList;
-}
-
-export function isLocalDatabaseDbItem(
-  dbItem: DbItem,
-): dbItem is LocalDatabaseDbItem {
-  return dbItem.kind === DbItemKind.LocalDatabase;
-}
-
 type SelectableDbItem = RemoteDbItem | LocalDbItem;
 
 export function isSelectableDbItem(dbItem: DbItem): dbItem is SelectableDbItem {

extensions/ql-vscode/src/databases/db-manager.ts

@@ -3,14 +3,7 @@ import { AppEvent, AppEventEmitter } from "../common/events";
 import { ValueResult } from "../common/value-result";
 import { DisposableObject } from "../common/disposable-object";
 import { DbConfigStore } from "./config/db-config-store";
-import {
-  DbItem,
-  DbItemKind,
-  DbListKind,
-  LocalDatabaseDbItem,
-  LocalListDbItem,
-  RemoteUserDefinedListDbItem,
-} from "./db-item";
+import { DbItem, RemoteUserDefinedListDbItem } from "./db-item";
 import {
   updateExpandedItem,
   replaceExpandedItem,
@@ -116,31 +109,15 @@ export class DbManager extends DisposableObject {
     await this.dbConfigStore.addRemoteOwner(owner);
   }
 
-  public async addNewList(
-    listKind: DbListKind,
-    listName: string,
-  ): Promise<void> {
-    switch (listKind) {
-      case DbListKind.Local:
-        await this.dbConfigStore.addLocalList(listName);
-        break;
-      case DbListKind.Remote:
-        await this.dbConfigStore.addRemoteList(listName);
-        break;
-      default:
-        throw Error(`Unknown list kind '${listKind}'`);
-    }
+  public async addNewList(listName: string): Promise<void> {
+    await this.dbConfigStore.addRemoteList(listName);
   }
 
   public async renameList(
-    currentDbItem: LocalListDbItem | RemoteUserDefinedListDbItem,
+    currentDbItem: RemoteUserDefinedListDbItem,
     newName: string,
   ): Promise<void> {
-    if (currentDbItem.kind === DbItemKind.LocalList) {
-      await this.dbConfigStore.renameLocalList(currentDbItem, newName);
-    } else if (currentDbItem.kind === DbItemKind.RemoteUserDefinedList) {
-      await this.dbConfigStore.renameRemoteList(currentDbItem, newName);
-    }
+    await this.dbConfigStore.renameRemoteList(currentDbItem, newName);
 
     const newDbItem = { ...currentDbItem, listName: newName };
     const newExpandedItems = replaceExpandedItem(
@@ -152,26 +129,8 @@ export class DbManager extends DisposableObject {
     await this.setExpandedItems(newExpandedItems);
   }
 
-  public async renameLocalDb(
-    currentDbItem: LocalDatabaseDbItem,
-    newName: string,
-  ): Promise<void> {
-    await this.dbConfigStore.renameLocalDb(
-      currentDbItem,
-      newName,
-      currentDbItem.parentListName,
-    );
-  }
-
-  public doesListExist(listKind: DbListKind, listName: string): boolean {
-    switch (listKind) {
-      case DbListKind.Local:
-        return this.dbConfigStore.doesLocalListExist(listName);
-      case DbListKind.Remote:
-        return this.dbConfigStore.doesRemoteListExist(listName);
-      default:
-        throw Error(`Unknown list kind '${listKind}'`);
-    }
+  public doesListExist(listName: string): boolean {
+    return this.dbConfigStore.doesRemoteListExist(listName);
   }
 
   public doesRemoteOwnerExist(owner: string): boolean {
@@ -182,10 +141,6 @@ export class DbManager extends DisposableObject {
     return this.dbConfigStore.doesRemoteDbExist(nwo, listName);
   }
 
-  public doesLocalDbExist(dbName: string, listName?: string): boolean {
-    return this.dbConfigStore.doesLocalDbExist(dbName, listName);
-  }
-
   private getExpandedItems(): ExpandedDbItem[] {
     const items = this.app.workspaceState.get<ExpandedDbItem[]>(
       DbManager.DB_EXPANDED_STATE_KEY,

extensions/ql-vscode/src/databases/ui/db-panel.ts

@@ -17,12 +17,7 @@ import {
   isValidGitHubOwner,
 } from "../../common/github-url-identifier-helper";
 import { DisposableObject } from "../../common/disposable-object";
-import {
-  DbItem,
-  DbItemKind,
-  DbListKind,
-  RemoteUserDefinedListDbItem,
-} from "../db-item";
+import { DbItem, DbItemKind, RemoteUserDefinedListDbItem } from "../db-item";
 import { getDbItemName } from "../db-item-naming";
 import { DbManager } from "../db-manager";
 import { DbTreeDataProvider } from "./db-tree-data-provider";
@@ -217,8 +212,6 @@ export class DbPanel extends DisposableObject {
   }
 
   private async addNewList(): Promise<void> {
-    const listKind = DbListKind.Remote;
-
     const listName = await window.showInputBox({
       prompt: "Enter a name for the new list",
       placeHolder: "example-list",
@@ -227,15 +220,15 @@ export class DbPanel extends DisposableObject {
       return;
     }
 
-    if (this.dbManager.doesListExist(listKind, listName)) {
+    if (this.dbManager.doesListExist(listName)) {
       void showAndLogErrorMessage(
         this.app.logger,
         `The list '${listName}' already exists`,
       );
       return;
     }
 
-    await this.dbManager.addNewList(listKind, listName);
+    await this.dbManager.addNewList(listName);
   }
 
   private async setSelectedItem(treeViewItem: DbTreeViewItem): Promise<void> {
@@ -286,7 +279,7 @@ export class DbPanel extends DisposableObject {
       return;
     }
 
-    if (this.dbManager.doesListExist(DbListKind.Remote, newName)) {
+    if (this.dbManager.doesListExist(newName)) {
       void showAndLogErrorMessage(
         this.app.logger,
         `The list '${newName}' already exists`,