Convert updateSelectionCallback to not use double-nested methods

Author: robertbrignull

extensions/ql-vscode/src/view/results/AlertTable.tsx

@@ -75,13 +75,11 @@ export class AlertTable extends React.Component<
     const updateSelectionCallback = (
       resultKey: Keys.PathNode | Keys.Result | undefined,
     ) => {
-      return () => {
-        this.setState((previousState) => ({
-          ...previousState,
-          selectedItem: resultKey,
-        }));
-        sendTelemetry("local-results-alert-table-path-selected");
-      };
+      this.setState((previousState) => ({
+        ...previousState,
+        selectedItem: resultKey,
+      }));
+      sendTelemetry("local-results-alert-table-path-selected");
     };
 
     if (!resultSet.interpretation.data.runs?.[0]?.results?.length) {

extensions/ql-vscode/src/view/results/AlertTablePathNodeRow.tsx

@@ -4,7 +4,7 @@ import * as Keys from "./result-keys";
 import { SarifLocation } from "./locations/SarifLocation";
 import { selectableZebraStripe } from "./result-table-utils";
 import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
-import { useMemo } from "react";
+import { useCallback, useMemo } from "react";
 
 interface Props {
   step: Sarif.ThreadFlowLocation;
@@ -16,7 +16,7 @@ interface Props {
   sourceLocationPrefix: string;
   updateSelectionCallback: (
     resultKey: Keys.PathNode | Keys.Result | undefined,
-  ) => () => void;
+  ) => void;
   scroller: ScrollIntoViewHelper;
 }
 
@@ -41,7 +41,7 @@ export function AlertTablePathNodeRow(props: Props) {
     }),
     [pathIndex, pathNodeIndex, resultIndex],
   );
-  const handleSarifLocationClicked = useMemo(
+  const handleSarifLocationClicked = useCallback(
     () => updateSelectionCallback(pathNodeKey),
     [pathNodeKey, updateSelectionCallback],
   );

extensions/ql-vscode/src/view/results/AlertTablePathRow.tsx

@@ -17,7 +17,7 @@ interface Props {
   sourceLocationPrefix: string;
   updateSelectionCallback: (
     resultKey: Keys.PathNode | Keys.Result | undefined,
-  ) => () => void;
+  ) => void;
   toggleExpanded: (e: React.MouseEvent, keys: Keys.ResultKey[]) => void;
   scroller: ScrollIntoViewHelper;
 }

extensions/ql-vscode/src/view/results/AlertTableResultRow.tsx

@@ -19,7 +19,7 @@ interface Props {
   sourceLocationPrefix: string;
   updateSelectionCallback: (
     resultKey: Keys.PathNode | Keys.Result | undefined,
-  ) => () => void;
+  ) => void;
   toggleExpanded: (e: React.MouseEvent, keys: Keys.ResultKey[]) => void;
   scroller: ScrollIntoViewHelper;
 }
@@ -42,7 +42,7 @@ export function AlertTableResultRow(props: Props) {
     [resultIndex],
   );
 
-  const handleSarifLocationClicked = useMemo(
+  const handleSarifLocationClicked = useCallback(
     () => updateSelectionCallback(resultKey),
     [resultKey, updateSelectionCallback],
   );