Merge pull request #2912 from github/robertbrignull/simplify_messages/RevealMethodMessage

robertbrignull · web-flow · commit af334a98e3c4 · 2023-10-09T10:46:19.000+01:00
Convert RevealMethodMessage to only include method signature
diff --git a/extensions/ql-vscode/src/common/interface-types.ts b/extensions/ql-vscode/src/common/interface-types.ts
@@ -587,7 +587,7 @@ interface SetInModelingModeMessage {
 
 interface RevealMethodMessage {
   t: "revealMethod";
-  method: Method;
+  methodSignature: string;
 }
 
 export type ToModelEditorMessage =
diff --git a/extensions/ql-vscode/src/model-editor/model-editor-view.ts b/extensions/ql-vscode/src/model-editor/model-editor-view.ts
@@ -328,7 +328,7 @@ export class ModelEditorView extends AbstractWebview<
 
     await this.postMessage({
       t: "revealMethod",
-      method,
+      methodSignature: method.signature,
     });
   }
 
diff --git a/extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx b/extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx
@@ -142,7 +142,7 @@ export function ModelEditor({
             );
             break;
           case "revealMethod":
-            setRevealedMethodSignature(msg.method.signature);
+            setRevealedMethodSignature(msg.methodSignature);
 
             break;
           default:

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,7 @@ interface SetInModelingModeMessage {`
`587`	`587`
`588`	`588`	`interface RevealMethodMessage {`
`589`	`589`	`t: "revealMethod";`
`590`		`- method: Method;`
	`590`	`+ methodSignature: string;`
`591`	`591`	`}`
`592`	`592`
`593`	`593`	`export type ToModelEditorMessage =`
Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ export class ModelEditorView extends AbstractWebview<`
`328`	`328`
`329`	`329`	`await this.postMessage({`
`330`	`330`	`t: "revealMethod",`
`331`		`- method,`
	`331`	`+ methodSignature: method.signature,`
`332`	`332`	`});`
`333`	`333`	`}`
`334`	`334`