Skip to content

Commit b03efa4

Browse files
committed
Merge remote-tracking branch 'origin/main' into koesie10/source-map-script-from-release-asset
2 parents f3f8de0 + 2b816f9 commit b03efa4

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,13 @@ Pre-recorded scenarios are stored in `./src/mocks/scenarios`. However, it's poss
228228
1. Double-check the `CHANGELOG.md` contains all desired change comments and has the version to be released with date at the top.
229229
* Go through all recent PRs and make sure they are properly accounted for.
230230
* Make sure all changelog entries have links back to their PR(s) if appropriate.
231+
* For picking the new version number, we default to increasing the patch version number, but make our own judgement about whether a change is big enough to warrant a minor version bump. Common reasons for a minor bump could include:
232+
* Making substantial new features available to all users. This can include lifting a feature flag.
233+
* Breakage in compatibility with recent versions of the CLI.
234+
* Minimum required version of VS Code is increased.
235+
* New telemetry events are added.
236+
* Deprecation or removal of commands.
237+
* Accumulation of many changes, none of which are individually big enough to warrant a minor bump, but which together are. This does not include changes which are purely internal to the extension, such as refactoring, or which are only available behind a feature flag.
231238
1. Double-check that the node version we're using matches the one used for VS Code. If it doesn't, you will then need to update the node version in the following files:
232239
* `.nvmrc` - this will enable `nvm` to automatically switch to the correct node version when you're in the project folder
233240
* `.github/workflows/main.yml` - all the "node-version: <version>" settings

extensions/ql-vscode/supported_cli_versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[
2-
"v2.12.1",
2+
"v2.12.2",
33
"v2.11.6",
44
"v2.7.6",
55
"v2.8.5",

0 commit comments

Comments
 (0)