Move showResultsForComparison to top level

Author: robertbrignull

extensions/ql-vscode/src/extension.ts

@@ -701,7 +701,7 @@ async function activateWithInstalledDistribution(
     queryHistoryConfigurationListener,
     labelProvider,
     async (from: CompletedLocalQueryInfo, to: CompletedLocalQueryInfo) =>
-      showResultsForComparison(from, to),
+      showResultsForComparison(compareView, from, to),
   );
 
   ctx.subscriptions.push(qhm);
@@ -729,21 +729,6 @@ async function activateWithInstalledDistribution(
   void extLogger.log("Initializing source archive filesystem provider.");
   archiveFilesystemProvider_activate(ctx);
 
-  async function showResultsForComparison(
-    from: CompletedLocalQueryInfo,
-    to: CompletedLocalQueryInfo,
-  ): Promise<void> {
-    try {
-      await compareView.showResults(from, to);
-    } catch (e) {
-      void showAndLogExceptionWithTelemetry(
-        redactableError(asError(e))`Failed to show results: ${getErrorMessage(
-          e,
-        )}`,
-      );
-    }
-  }
-
   async function showResultsForCompletedQuery(
     query: CompletedLocalQueryInfo,
     forceReveal: WebviewReveal,
@@ -1729,6 +1714,22 @@ async function activateWithInstalledDistribution(
   };
 }
 
+async function showResultsForComparison(
+  compareView: CompareView,
+  from: CompletedLocalQueryInfo,
+  to: CompletedLocalQueryInfo,
+): Promise<void> {
+  try {
+    await compareView.showResults(from, to);
+  } catch (e) {
+    void showAndLogExceptionWithTelemetry(
+      redactableError(asError(e))`Failed to show results: ${getErrorMessage(
+        e,
+      )}`,
+    );
+  }
+}
+
 function addUnhandledRejectionListener() {
   const handler = (error: unknown) => {
     // This listener will be triggered for errors from other extensions as