Skip to content

Commit b27d8a1

Browse files
Merge pull request #3183 from github/robertbrignull/remove_releases_repo_config
Remove ownerName and repositoryName from DistributionConfig
2 parents 1ad20fa + b082455 commit b27d8a1

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

extensions/ql-vscode/src/codeql-cli/distribution.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -512,19 +512,15 @@ class ExtensionSpecificDistributionManager {
512512
}
513513

514514
private get distributionOwnerName(): string {
515-
if (this.config.ownerName) {
516-
return this.config.ownerName;
517-
} else if (this.config.channel === "nightly") {
515+
if (this.config.channel === "nightly") {
518516
return NIGHTLY_DISTRIBUTION_OWNER_NAME;
519517
} else {
520518
return DEFAULT_DISTRIBUTION_OWNER_NAME;
521519
}
522520
}
523521

524522
private get distributionRepositoryName(): string {
525-
if (this.config.repositoryName) {
526-
return this.config.repositoryName;
527-
} else if (this.config.channel === "nightly") {
523+
if (this.config.channel === "nightly") {
528524
return NIGHTLY_DISTRIBUTION_REPOSITORY_NAME;
529525
} else {
530526
return DEFAULT_DISTRIBUTION_REPOSITORY_NAME;

extensions/ql-vscode/src/config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,6 @@ export interface DistributionConfig {
119119
updateCustomCodeQlPath: (newPath: string | undefined) => Promise<void>;
120120
includePrerelease: boolean;
121121
personalAccessToken?: string;
122-
ownerName?: string;
123-
repositoryName?: string;
124122
channel: CLIChannel;
125123
onDidChangeConfiguration?: Event<void>;
126124
}

0 commit comments

Comments
 (0)