Fix linting errors resulting from upgrading @typescript-eslint/eslint-plugin to version 8

Author: robertbrignull

extensions/ql-vscode/.eslintignore

@@ -3,5 +3,14 @@ node_modules/
 out/
 build/
 
+# Ignore js files
+.eslintrc.js
+jest.config.js
+test/vscode-tests/activated-extension/jest-runner-vscode.config.js
+test/vscode-tests/cli-integration/jest-runner-vscode.config.js
+test/vscode-tests/jest-runner-vscode.config.base.js
+test/vscode-tests/minimal-workspace/jest-runner-vscode.config.js
+test/vscode-tests/no-workspace/jest-runner-vscode.config.js
+
 # Include the Storybook config
 !.storybook

extensions/ql-vscode/.eslintrc.js

@@ -45,7 +45,7 @@ const baseConfig = {
     "@typescript-eslint/no-invalid-this": "off",
     "@typescript-eslint/no-shadow": "off",
     "prefer-const": ["warn", { destructuring: "all" }],
-    "@typescript-eslint/no-throw-literal": "error",
+    "@typescript-eslint/only-throw-error": "error",
     "@typescript-eslint/consistent-type-imports": "error",
     "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
     curly: ["error", "all"],
@@ -133,18 +133,7 @@ module.exports = {
         ...baseConfig.rules,
         // We want to allow mocking of functions in modules, so we need to allow namespace imports.
         "import/no-namespace": "off",
-        "@typescript-eslint/ban-types": [
-          "error",
-          {
-            // For a full list of the default banned types, see:
-            // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/ban-types.md
-            extendDefaults: true,
-            types: {
-              // Don't complain about the `Function` type in test files. (Default is `true`.)
-              Function: false,
-            },
-          },
-        ],
+        "@typescript-eslint/no-unsafe-function-type": "off",
       },
     },
     {

extensions/ql-vscode/gulpfile.ts/appInsights.ts

@@ -1,5 +1,5 @@
 import { src, dest } from "gulp";
-// eslint-disable-next-line @typescript-eslint/no-var-requires,import/no-commonjs
+// eslint-disable-next-line @typescript-eslint/no-require-imports,import/no-commonjs
 const replace = require("gulp-replace");
 
 /** Inject the application insights key into the telemetry file */

extensions/ql-vscode/src/codeql-cli/cli.ts

@@ -943,7 +943,7 @@ export class CodeQLCliServer implements Disposable {
           if (line.startsWith("Enter value for --github-auth-stdin")) {
             try {
               return await this.app.credentials.getAccessToken();
-            } catch (e) {
+            } catch {
               // If the user cancels the authentication prompt, we still need to give a value to the CLI.
               // By giving a potentially invalid value, the user will just get a 401/403 when they try to access a
               // private package and the access token is invalid.

extensions/ql-vscode/src/codeql-cli/query-language.ts

@@ -36,7 +36,7 @@ export async function findLanguage(
       void extLogger.log(
         "Query language is unsupported. Select language manually.",
       );
-    } catch (e) {
+    } catch {
       void extLogger.log(
         "Could not autodetect query language. Select language manually.",
       );

extensions/ql-vscode/src/common/github-url-identifier-helper.ts

@@ -78,7 +78,7 @@ function getNwoOrOwnerFromGitHubUrl(
     }
     const nwo = `${paths[0]}/${paths[1]}`;
     return paths[1] ? nwo : undefined;
-  } catch (e) {
+  } catch {
     // Ignore the error here, since we catch failures at a higher level.
     return;
   }

extensions/ql-vscode/src/common/readonly.ts

@@ -1,14 +1,14 @@
 export type DeepReadonly<T> =
   T extends Array<infer R>
     ? DeepReadonlyArray<R>
-    : // eslint-disable-next-line @typescript-eslint/ban-types
+    : // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
       T extends Function
       ? T
       : T extends object
         ? DeepReadonlyObject<T>
         : T;
 
-interface DeepReadonlyArray<T> extends ReadonlyArray<DeepReadonly<T>> {}
+type DeepReadonlyArray<T> = ReadonlyArray<DeepReadonly<T>>;
 
 type DeepReadonlyObject<T> = {
   readonly [P in keyof T]: DeepReadonly<T[P]>;

extensions/ql-vscode/src/databases/config/db-config-store.ts

@@ -298,7 +298,7 @@ export class DbConfigStore extends DisposableObject {
     let newConfig: DbConfig | undefined = undefined;
     try {
       newConfig = await readJSON(this.configPath);
-    } catch (e) {
+    } catch {
       this.configErrors = [
         {
           kind: DbConfigValidationErrorKind.InvalidJson,
@@ -332,7 +332,7 @@ export class DbConfigStore extends DisposableObject {
     let newConfig: DbConfig | undefined = undefined;
     try {
       newConfig = readJSONSync(this.configPath);
-    } catch (e) {
+    } catch {
       this.configErrors = [
         {
           kind: DbConfigValidationErrorKind.InvalidJson,

extensions/ql-vscode/src/databases/database-fetcher.ts

@@ -454,7 +454,7 @@ export class DatabaseFetcher {
     let uri;
     try {
       uri = Uri.parse(databaseUrl, true);
-    } catch (e) {
+    } catch {
       throw new Error(`Invalid url: ${databaseUrl}`);
     }
 
@@ -612,7 +612,7 @@ export class DatabaseFetcher {
       const obj = JSON.parse(text);
       msg =
         obj.error || obj.message || obj.reason || JSON.stringify(obj, null, 2);
-    } catch (e) {
+    } catch {
       msg = text;
     }
     throw new Error(`${errorMessage}.\n\nReason: ${msg}`);

extensions/ql-vscode/src/databases/local-databases/database-manager.ts

@@ -231,7 +231,7 @@ export class DatabaseManager extends DisposableObject {
     let originStat;
     try {
       originStat = await stat(originDbYml);
-    } catch (e) {
+    } catch {
       // if there is an error here, assume that the origin database
       // is no longer available. Safely ignore and do not try to re-import.
       return false;
@@ -240,7 +240,7 @@ export class DatabaseManager extends DisposableObject {
     try {
       const importedStat = await stat(importedDbYml);
       return originStat.mtimeMs > importedStat.mtimeMs;
-    } catch (e) {
+    } catch {
       // If either of the files does not exist, we assume the origin is newer.
       // This shouldn't happen unless the user manually deleted one of the files.
       return true;