Only show 'view SARIF' if SARIF exists.

Author: jcreedcmu

extensions/ql-vscode/package.json

@@ -395,7 +395,7 @@
         {
           "command": "codeQLQueryHistory.viewSarif",
           "group": "9_qlCommands",
-          "when": "view == codeQLQueryHistory"
+          "when": "view == codeQLQueryHistory && viewItem == interpretedResultsItem"
         },
         {
           "command": "codeQLTests.showOutputDifferences",

extensions/ql-vscode/src/interface.ts

@@ -440,7 +440,7 @@ export class InterfaceManager extends DisposableObject {
   ): Promise<Interpretation | undefined> {
     let interpretation: Interpretation | undefined = undefined;
     if (
-      (await query.hasInterpretedResults()) &&
+      (await query.canHaveInterpretedResults()) &&
       query.quickEvalPosition === undefined // never do results interpretation if quickEval
     ) {
       try {

extensions/ql-vscode/src/query-history.ts

@@ -83,6 +83,11 @@ class HistoryTreeDataProvider implements vscode.TreeDataProvider<CompletedQuery>
       arguments: [element],
     };
 
+    // Mark this query history item according to whether it has a
+    // SARIF file so that we can make context menu items conditionally
+    // available.
+    it.contextValue = element.query.hasInterpretedResults() ? 'interpretedResultsItem' : 'rawResultsItem';
+
     if (!element.didRunSuccessfully) {
       it.iconPath = path.join(this.ctx.extensionPath, FAILED_QUERY_HISTORY_ITEM_ICON);
     }
@@ -259,7 +264,7 @@ export class QueryHistoryManager {
 
   async handleViewSarif(queryHistoryItem: CompletedQuery) {
     try {
-      const hasInterpretedResults = await queryHistoryItem.query.hasInterpretedResults();
+      const hasInterpretedResults = await queryHistoryItem.query.canHaveInterpretedResults();
       if (hasInterpretedResults) {
         const textDocument = await vscode.workspace.openTextDocument(vscode.Uri.file(queryHistoryItem.query.resultsPaths.interpretedResultsPath));
         await vscode.window.showTextDocument(textDocument, vscode.ViewColumn.One);

extensions/ql-vscode/src/run-queries.ts

@@ -157,15 +157,22 @@ export class QueryInfo {
   }
 
   /**
-   * Holds if this query should produce interpreted results.
+   * Holds if this query can in principle produce interpreted results.
    */
-  async hasInterpretedResults(): Promise<boolean> {
+  async canHaveInterpretedResults(): Promise<boolean> {
     const hasMetadataFile = await this.dbItem.hasMetadataFile();
     if (!hasMetadataFile) {
       logger.log("Cannot produce interpreted results since the database does not have a .dbinfo or codeql-database.yml file.");
     }
     return hasMetadataFile;
   }
+
+  /**
+   * Holds if this query actually has produced interpreted results.
+   */
+  hasInterpretedResults(): boolean {
+    return fs.existsSync(this.resultsPaths.interpretedResultsPath);
+  }
 }
 
 export interface QueryWithResults {