Skip to content

Commit bb24614

Browse files
Add comments to createDataExtensionYamlsForFrameworkMode too
1 parent 5b170d0 commit bb24614

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • extensions/ql-vscode/src/data-extensions-editor

extensions/ql-vscode/src/data-extensions-editor/yaml.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,12 +168,15 @@ export function createDataExtensionYamlsForFrameworkMode(
168168

169169
const methods: Record<string, ModeledMethod> = {};
170170

171+
// First populate methodsByLibraryFilename with any existing modeled methods.
171172
for (const [signature, method] of Object.entries(
172173
existingModeledMethods[filename] || {},
173174
)) {
174175
methods[signature] = method;
175176
}
176177

178+
// Add the new modeled methods, potentially overwriting existing modeled methods
179+
// but not removing existing modeled methods that are not in the new set.
177180
for (const externalApiUsage of externalApiUsages) {
178181
const modeledMethod = newModeledMethods[externalApiUsage.signature];
179182
if (modeledMethod) {

0 commit comments

Comments
 (0)