lint: Add proper linting for react

Author: aeisenberg

common/config/rush/pnpm-lock.yaml

@@ -27,4 +27,4 @@
     "../../test",
     "../../**/view"
   ]
-}
+}

configs/typescript-config/common.tsconfig.json

@@ -3,9 +3,6 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018,
     sourceType: 'module',
-    ecmaFeatures: {
-      modules: true,
-    },
     project: ['tsconfig.json', './src/**/tsconfig.json'],
   },
   plugins: ['@typescript-eslint'],
@@ -33,6 +30,7 @@ module.exports = {
       "SwitchCase": 1,
       "FunctionDeclaration": { "body": 1, "parameters": 1 }
     }],
-    "@typescript-eslint/no-throw-literal": "error"
+    "@typescript-eslint/no-throw-literal": "error",
+    "no-useless-escape": 0
   },
 };

extensions/ql-vscode/.eslintrc.js

@@ -389,7 +389,7 @@
     "update-vscode": "node ./node_modules/vscode/bin/install",
     "postinstall": "node ./node_modules/vscode/bin/install",
     "format": "tsfmt -r",
-    "lint": "eslint . --ext .ts,.tsx"
+    "lint": "eslint src test --ext .ts,.tsx"
   },
   "dependencies": {
     "child-process-promise": "^2.2.1",
@@ -465,6 +465,7 @@
     "sinon-chai": "~3.5.0",
     "@types/sinon-chai": "~3.2.3",
     "proxyquire": "~2.1.3",
-    "@types/proxyquire": "~1.3.28"
+    "@types/proxyquire": "~1.3.28",
+    "eslint-plugin-react": "~7.19.0"
   }
 }

extensions/ql-vscode/package.json

@@ -430,21 +430,23 @@ class DatabaseItemImpl implements DatabaseItem {
  */
 function eventFired<T>(event: vscode.Event<T>, timeoutMs = 1000): Promise<T | undefined> {
   return new Promise((res, _rej) => {
-    let timeout: NodeJS.Timeout | undefined;
-    let disposable: vscode.Disposable | undefined;
-    function dispose() {
-      if (timeout !== undefined) clearTimeout(timeout);
-      if (disposable !== undefined) disposable.dispose();
-    }
-    disposable = event(e => {
-      res(e);
-      dispose();
-    });
-    timeout = setTimeout(() => {
+    const timeout = setTimeout(() => {
       logger.log(`Waiting for event ${event} timed out after ${timeoutMs}ms`);
       res(undefined);
       dispose();
     }, timeoutMs);
+    const disposable = event(e => {
+      res(e);
+      dispose();
+    });
+    function dispose() {
+      if (timeout !== undefined) {
+        clearTimeout(timeout);
+      }
+      if (disposable !== undefined) {
+        disposable.dispose();
+      }
+    }
   });
 }
 

extensions/ql-vscode/src/databases.ts

@@ -64,7 +64,7 @@ export class QLTestDirectory extends QLTestNode {
   private createChildDirectory(name: string): QLTestDirectory {
     const existingChild = this._children.find((child) => child.name === name);
     if (existingChild !== undefined) {
-      return <QLTestDirectory>existingChild;
+      return existingChild as QLTestDirectory;
     }
     else {
       const newChild = new QLTestDirectory(path.join(this.path, name), name);
@@ -87,6 +87,7 @@ export class QLTestFile extends QLTestNode {
   }
 
   public finish(): void {
+    /**/
   }
 }