Skip to content

Commit bbc39b0

Browse files
committed
Remove library column
1 parent 590e908 commit bbc39b0

2 files changed

Lines changed: 12 additions & 18 deletions

File tree

extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -149,17 +149,14 @@ export const MethodRow = ({
149149
return (
150150
<VSCodeDataGridRow>
151151
<VSCodeDataGridCell gridColumn={1}>
152-
{externalApiUsage.library}
153-
</VSCodeDataGridCell>
154-
<VSCodeDataGridCell gridColumn={2}>
155152
<SupportSpan
156153
supported={externalApiUsage.supported}
157154
modeled={modeledMethod}
158155
>
159156
{externalApiUsage.packageName}.{externalApiUsage.typeName}
160157
</SupportSpan>
161158
</VSCodeDataGridCell>
162-
<VSCodeDataGridCell gridColumn={3}>
159+
<VSCodeDataGridCell gridColumn={2}>
163160
<SupportSpan
164161
supported={externalApiUsage.supported}
165162
modeled={modeledMethod}
@@ -168,12 +165,12 @@ export const MethodRow = ({
168165
{externalApiUsage.methodParameters}
169166
</SupportSpan>
170167
</VSCodeDataGridCell>
171-
<VSCodeDataGridCell gridColumn={4}>
168+
<VSCodeDataGridCell gridColumn={3}>
172169
<UsagesButton onClick={jumpToUsage}>
173170
{externalApiUsage.usages.length}
174171
</UsagesButton>
175172
</VSCodeDataGridCell>
176-
<VSCodeDataGridCell gridColumn={5}>
173+
<VSCodeDataGridCell gridColumn={4}>
177174
{(!externalApiUsage.supported ||
178175
(modeledMethod && modeledMethod?.type !== "none")) && (
179176
<Dropdown
@@ -188,7 +185,7 @@ export const MethodRow = ({
188185
</Dropdown>
189186
)}
190187
</VSCodeDataGridCell>
191-
<VSCodeDataGridCell gridColumn={6}>
188+
<VSCodeDataGridCell gridColumn={5}>
192189
{modeledMethod?.type &&
193190
["sink", "summary"].includes(modeledMethod?.type) && (
194191
<Dropdown value={modeledMethod?.input} onInput={handleInputInput}>
@@ -201,7 +198,7 @@ export const MethodRow = ({
201198
</Dropdown>
202199
)}
203200
</VSCodeDataGridCell>
204-
<VSCodeDataGridCell gridColumn={7}>
201+
<VSCodeDataGridCell gridColumn={6}>
205202
{modeledMethod?.type &&
206203
["source", "summary"].includes(modeledMethod?.type) && (
207204
<Dropdown value={modeledMethod?.output} onInput={handleOutputInput}>
@@ -215,7 +212,7 @@ export const MethodRow = ({
215212
</Dropdown>
216213
)}
217214
</VSCodeDataGridCell>
218-
<VSCodeDataGridCell gridColumn={8}>
215+
<VSCodeDataGridCell gridColumn={7}>
219216
{predicate?.supportedKinds && (
220217
<KindInput
221218
kinds={predicate.supportedKinds}

extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodDataGrid.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,27 +26,24 @@ export const ModeledMethodDataGrid = ({
2626
<VSCodeDataGrid>
2727
<VSCodeDataGridRow rowType="header">
2828
<VSCodeDataGridCell cellType="columnheader" gridColumn={1}>
29-
Library
30-
</VSCodeDataGridCell>
31-
<VSCodeDataGridCell cellType="columnheader" gridColumn={2}>
3229
Type
3330
</VSCodeDataGridCell>
34-
<VSCodeDataGridCell cellType="columnheader" gridColumn={3}>
31+
<VSCodeDataGridCell cellType="columnheader" gridColumn={2}>
3532
Method
3633
</VSCodeDataGridCell>
37-
<VSCodeDataGridCell cellType="columnheader" gridColumn={4}>
34+
<VSCodeDataGridCell cellType="columnheader" gridColumn={3}>
3835
Usages
3936
</VSCodeDataGridCell>
40-
<VSCodeDataGridCell cellType="columnheader" gridColumn={5}>
37+
<VSCodeDataGridCell cellType="columnheader" gridColumn={4}>
4138
Model type
4239
</VSCodeDataGridCell>
43-
<VSCodeDataGridCell cellType="columnheader" gridColumn={6}>
40+
<VSCodeDataGridCell cellType="columnheader" gridColumn={5}>
4441
Input
4542
</VSCodeDataGridCell>
46-
<VSCodeDataGridCell cellType="columnheader" gridColumn={7}>
43+
<VSCodeDataGridCell cellType="columnheader" gridColumn={6}>
4744
Output
4845
</VSCodeDataGridCell>
49-
<VSCodeDataGridCell cellType="columnheader" gridColumn={8}>
46+
<VSCodeDataGridCell cellType="columnheader" gridColumn={7}>
5047
Kind
5148
</VSCodeDataGridCell>
5249
</VSCodeDataGridRow>

0 commit comments

Comments
 (0)