Fix some type errors in tests

Author: koesie10

extensions/ql-vscode/src/variant-analysis/run-remote-query.ts

@@ -541,7 +541,9 @@ async function getControllerRepoFromApi(
   }
 }
 
-export function removeWorkspaceRefs(qlpack: QlPack) {
+export function removeWorkspaceRefs(qlpack: {
+  dependencies: Record<string, string>;
+}) {
   for (const [key, value] of Object.entries(qlpack.dependencies || {})) {
     if (value === "${workspace}") {
       qlpack.dependencies[key] = "*";

extensions/ql-vscode/test/vscode-tests/cli-integration/variant-analysis/variant-analysis-manager.test.ts

@@ -31,6 +31,7 @@ import { mockedQuickPickItem } from "../../utils/mocking.helpers";
 import { QueryLanguage } from "../../../../src/common/query-language";
 import { readBundledPack } from "../../utils/bundled-pack-helpers";
 import { load } from "js-yaml";
+import { ExtensionPackMetadata } from "../../../../src/model-editor/extension-pack-metadata";
 
 describe("Variant Analysis Manager", () => {
   let cli: CodeQLCliServer;
@@ -379,7 +380,9 @@ describe("Variant Analysis Manager", () => {
         : "codeql-pack.yml";
       const qlpackContents = load(
         packFS.fileContents(packFileName).toString("utf-8"),
-      );
+      ) as ExtensionPackMetadata & {
+        dependencies: Record<string, string>;
+      };
       expect(qlpackContents.name).toEqual(expectedPackName);
       if (checkVersion) {
         expect(qlpackContents.version).toEqual("0.0.0");
@@ -393,7 +396,9 @@ describe("Variant Analysis Manager", () => {
       }
       const qlpackLockContents = load(
         packFS.fileContents("codeql-pack.lock.yml").toString("utf-8"),
-      );
+      ) as {
+        dependencies: Record<string, string>;
+      };
 
       const actualLockKeys = Object.keys(qlpackLockContents.dependencies);
 

extensions/ql-vscode/test/vscode-tests/global.helper.ts

@@ -89,7 +89,9 @@ export async function fixWorkspaceReferences(
 ): Promise<Record<string, string> | undefined> {
   if (!(await cli.cliConstraints.supportsWorkspaceReferences())) {
     // remove the workspace references from the qlpack
-    const qlpack = load(readFileSync(qlpackFileWithWorkspaceRefs, "utf8"));
+    const qlpack = load(readFileSync(qlpackFileWithWorkspaceRefs, "utf8")) as {
+      dependencies: Record<string, string>;
+    };
     const originalDeps = { ...qlpack.dependencies };
     removeWorkspaceRefs(qlpack);
     writeFileSync(qlpackFileWithWorkspaceRefs, dump(qlpack));
@@ -113,7 +115,9 @@ export async function restoreWorkspaceReferences(
   if (!originalDeps) {
     return;
   }
-  const qlpack = load(readFileSync(qlpackFileWithWorkspaceRefs, "utf8"));
+  const qlpack = load(readFileSync(qlpackFileWithWorkspaceRefs, "utf8")) as {
+    dependencies: Record<string, string>;
+  };
   qlpack.dependencies = originalDeps;
   writeFileSync(qlpackFileWithWorkspaceRefs, dump(qlpack));
 }