Fix bug in pluralize helper method

shati-patel · web-flow · commit bd81d3c4a732 · 2022-10-21T14:17:40.000+01:00
Correctly handle the zero case
diff --git a/extensions/ql-vscode/src/helpers.ts b/extensions/ql-vscode/src/helpers.ts
@@ -590,5 +590,5 @@ export async function* walkDirectory(dir: string): AsyncIterableIterator<string>
  * Example: Returns "N repository" if N is one, "N repositories" otherwise.
  */
 export function pluralize(numItems: number | undefined, singular: string, plural: string): string {
-  return numItems ? `${numItems} ${numItems === 1 ? singular : plural}` : '';
+  return numItems !== undefined ? `${numItems} ${numItems === 1 ? singular : plural}` : '';
 }

Original file line number	Diff line number	Diff line change
`@@ -590,5 +590,5 @@ export async function* walkDirectory(dir: string): AsyncIterableIterator<string>`
`590`	`590`	`* Example: Returns "N repository" if N is one, "N repositories" otherwise.`
`591`	`591`	`*/`
`592`	`592`	`export function pluralize(numItems: number \| undefined, singular: string, plural: string): string {`
`593`		- return numItems ? `${numItems} ${numItems === 1 ? singular : plural}` : '';
	`593`	+ return numItems !== undefined ? `${numItems} ${numItems === 1 ? singular : plural}` : '';
`594`	`594`	`}`