Skip to content

Commit be392b5

Browse files
Convert handleRenameDatabase to use createSingleSelectionCommand
1 parent 5bee5c6 commit be392b5

1 file changed

Lines changed: 8 additions & 14 deletions

File tree

extensions/ql-vscode/src/local-databases-ui.ts

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ import { isCanary } from "./config";
4646
import { App } from "./common/app";
4747
import { redactableError } from "./pure/errors";
4848
import { LocalDatabasesCommands } from "./common/commands";
49-
import { createMultiSelectionCommand } from "./common/selection-commands";
49+
import {
50+
createMultiSelectionCommand,
51+
createSingleSelectionCommand,
52+
} from "./common/selection-commands";
5053

5154
enum SortOrder {
5255
NameAsc = "NameAsc",
@@ -247,7 +250,10 @@ export class DatabaseUI extends DisposableObject {
247250
"codeQLDatabases.upgradeDatabase": createMultiSelectionCommand(
248251
this.handleUpgradeDatabase.bind(this),
249252
),
250-
"codeQLDatabases.renameDatabase": this.handleRenameDatabase.bind(this),
253+
"codeQLDatabases.renameDatabase": createSingleSelectionCommand(
254+
this.handleRenameDatabase.bind(this),
255+
"database",
256+
),
251257
"codeQLDatabases.openDatabaseFolder": this.handleOpenFolder.bind(this),
252258
"codeQLDatabases.addDatabaseSource": this.handleAddSource.bind(this),
253259
"codeQLDatabases.removeOrphanedDatabases":
@@ -668,10 +674,7 @@ export class DatabaseUI extends DisposableObject {
668674

669675
private async handleRenameDatabase(
670676
databaseItem: DatabaseItem,
671-
multiSelect: DatabaseItem[] | undefined,
672677
): Promise<void> {
673-
this.assertSingleDatabase(multiSelect);
674-
675678
const newName = await window.showInputBox({
676679
prompt: "Choose new database name",
677680
value: databaseItem.name,
@@ -812,13 +815,4 @@ export class DatabaseUI extends DisposableObject {
812815
}
813816
return Uri.file(dbPath);
814817
}
815-
816-
private assertSingleDatabase(
817-
multiSelect: DatabaseItem[] = [],
818-
message = "Please select a single database.",
819-
) {
820-
if (multiSelect.length > 1) {
821-
throw new Error(message);
822-
}
823-
}
824818
}

0 commit comments

Comments
 (0)