Skip to content

Commit c247292

Browse files
authored
Merge pull request #537 from jcreedcmu/jcreed/fix-paginated-sorting
Fix changing page forgetting about sorting
2 parents 1f4e699 + 518e6c1 commit c247292

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 1.3.3 - [UNRELEASED]
44

55
- Fix display of raw results entities with label but no url.
6+
- Fix bug where sort order is forgotten when changing raw results page
67

78
## 1.3.2 - 12 August 2020
89

extensions/ql-vscode/src/interface.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,15 @@ export class InterfaceManager extends DisposableObject {
270270
await this.showPageOfInterpretedResults(msg.pageNumber);
271271
}
272272
else {
273-
await this.showPageOfRawResults(msg.selectedTable, msg.pageNumber);
273+
await this.showPageOfRawResults(
274+
msg.selectedTable,
275+
msg.pageNumber,
276+
// When we are in an unsorted state, we guarantee that
277+
// sortedResultsInfo doesn't have an entry for the current
278+
// result set. Use this to determine whether or not we use
279+
// the sorted bqrs file.
280+
this._displayedQuery?.sortedResultsInfo.has(msg.selectedTable) || false
281+
);
274282
}
275283
break;
276284
default:

0 commit comments

Comments
 (0)