Skip to content

Commit c4396b7

Browse files
committed
Rename KindInput to ModelKindDropdown
1 parent 4e09640 commit c4396b7

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { vscode } from "../vscode-api";
1111

1212
import { Method } from "../../model-editor/method";
1313
import { ModeledMethod } from "../../model-editor/modeled-method";
14-
import { KindInput } from "./KindInput";
14+
import { ModelKindDropdown } from "./ModelKindDropdown";
1515
import { extensiblePredicateDefinitions } from "../../model-editor/predicates";
1616
import { Mode } from "../../model-editor/shared/mode";
1717
import { MethodClassifications } from "./MethodClassifications";
@@ -154,7 +154,7 @@ function ModelableMethodRow(props: MethodRowProps) {
154154
/>
155155
</VSCodeDataGridCell>
156156
<VSCodeDataGridCell gridColumn={5}>
157-
<KindInput
157+
<ModelKindDropdown
158158
kinds={predicate?.supportedKinds || []}
159159
value={modeledMethod?.kind}
160160
disabled={!showKindCell}

extensions/ql-vscode/src/view/model-editor/KindInput.tsx renamed to extensions/ql-vscode/src/view/model-editor/ModelKindDropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type Props = {
1313
"aria-label"?: string;
1414
};
1515

16-
export const KindInput = ({
16+
export const ModelKindDropdown = ({
1717
kinds,
1818
value,
1919
disabled,

extensions/ql-vscode/src/view/model-editor/__tests__/KindInput.spec.tsx renamed to extensions/ql-vscode/src/view/model-editor/__tests__/ModelKindDropdown.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import * as React from "react";
22
import { render, screen } from "@testing-library/react";
3-
import { KindInput } from "../KindInput";
3+
import { ModelKindDropdown } from "../ModelKindDropdown";
44
import userEvent from "@testing-library/user-event";
55

6-
describe(KindInput.name, () => {
6+
describe(ModelKindDropdown.name, () => {
77
const onChange = jest.fn();
88

99
beforeEach(() => {
@@ -12,7 +12,7 @@ describe(KindInput.name, () => {
1212

1313
it("allows changing the kind", async () => {
1414
render(
15-
<KindInput
15+
<ModelKindDropdown
1616
kinds={["local", "remote"]}
1717
value="local"
1818
onChange={onChange}
@@ -26,7 +26,7 @@ describe(KindInput.name, () => {
2626

2727
it("resets the kind when changing the supported kinds", () => {
2828
const { rerender } = render(
29-
<KindInput
29+
<ModelKindDropdown
3030
kinds={["local", "remote"]}
3131
value={"local"}
3232
onChange={onChange}
@@ -37,7 +37,7 @@ describe(KindInput.name, () => {
3737
expect(onChange).not.toHaveBeenCalled();
3838

3939
rerender(
40-
<KindInput
40+
<ModelKindDropdown
4141
kinds={["sql-injection", "log-injection", "url-redirection"]}
4242
value="local"
4343
onChange={onChange}
@@ -49,7 +49,7 @@ describe(KindInput.name, () => {
4949

5050
it("sets the kind when value is undefined", () => {
5151
render(
52-
<KindInput
52+
<ModelKindDropdown
5353
kinds={["local", "remote"]}
5454
value={undefined}
5555
onChange={onChange}

0 commit comments

Comments
 (0)