Merge pull request #1397 from github/elenatanasoiu/improve-mrva-controller-feedback

elenatanasoiu · web-flow · commit c84b858205cb · 2022-06-22T17:03:26.000+01:00
MRVA: Improve experience when controller repo does not exist
diff --git a/extensions/ql-vscode/src/remote-queries/run-remote-query.ts b/extensions/ql-vscode/src/remote-queries/run-remote-query.ts
@@ -334,8 +334,12 @@ async function runRemoteQueriesApiRequest(
     const { popupMessage, logMessage } = parseResponse(owner, repo, response.data);
     void showAndLogInformationMessage(popupMessage, { fullMessage: logMessage });
     return response.data.workflow_run_id;
-  } catch (error) {
-    void showAndLogErrorMessage(getErrorMessage(error));
+  } catch (error: any) {
+    if (error.status === 404) {
+      void showAndLogErrorMessage(`Controller repository was not found. Please make sure it's a valid repo name.${eol}`);
+    } else {
+      void showAndLogErrorMessage(getErrorMessage(error));
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -334,8 +334,12 @@ async function runRemoteQueriesApiRequest(`
`334`	`334`	`const { popupMessage, logMessage } = parseResponse(owner, repo, response.data);`
`335`	`335`	`void showAndLogInformationMessage(popupMessage, { fullMessage: logMessage });`
`336`	`336`	`return response.data.workflow_run_id;`
`337`		`- } catch (error) {`
`338`		`- void showAndLogErrorMessage(getErrorMessage(error));`
	`337`	`+ } catch (error: any) {`
	`338`	`+ if (error.status === 404) {`
	`339`	+ void showAndLogErrorMessage(`Controller repository was not found. Please make sure it's a valid repo name.${eol}`);
	`340`	`+ } else {`
	`341`	`+ void showAndLogErrorMessage(getErrorMessage(error));`
	`342`	`+ }`
`339`	`343`	`}`
`340`	`344`	`}`
`341`	`345`