Skip to content

Commit cd8d82d

Browse files
committed
Add query text to variant analysis submission
This will add a new query text field to the variant analysis submission, which will also propagate to the variant analysis itself. This will allow us to show the query text on the variant analysis page.
1 parent 8c324a3 commit cd8d82d

9 files changed

Lines changed: 16 additions & 8 deletions

File tree

extensions/ql-vscode/src/remote-queries/run-remote-query.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,8 @@ export async function runRemoteQuery(
251251
throw new UserCancellationException(`Found unsupported language: ${language}`);
252252
}
253253

254+
const queryText = await fs.readFile(queryFile, 'utf8');
255+
254256
const variantAnalysisSubmission: VariantAnalysisSubmission = {
255257
startTime: queryStartTime,
256258
actionRepoRef: actionBranch,
@@ -260,6 +262,7 @@ export async function runRemoteQuery(
260262
filePath: queryFile,
261263
pack: base64Pack,
262264
language: variantAnalysisLanguage,
265+
queryText,
263266
},
264267
databases: {
265268
repositories: repoSelection.repositories,

extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ export interface VariantAnalysis {
77
query: {
88
name: string,
99
filePath: string,
10-
language: VariantAnalysisQueryLanguage
10+
language: VariantAnalysisQueryLanguage,
11+
queryText: string,
1112
},
1213
databases: {
1314
repositories?: string[],
@@ -113,6 +114,7 @@ export interface VariantAnalysisSubmission {
113114
name: string,
114115
filePath: string,
115116
language: VariantAnalysisQueryLanguage,
117+
queryText: string,
116118

117119
// Base64 encoded query pack.
118120
pack: string,

extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
183183
name: `Variant analysis ${variantAnalysisId}`,
184184
filePath: `variant_analysis_${variantAnalysisId}.ql`,
185185
language: variantAnalysisResponse.query_language as VariantAnalysisQueryLanguage,
186+
queryText: '',
186187
},
187188
databases: {}
188189
}, variantAnalysisResponse);

extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ export function processVariantAnalysis(
2727
query: {
2828
name: submission.query.name,
2929
filePath: submission.query.filePath,
30-
language: submission.query.language
30+
language: submission.query.language,
31+
queryText: submission.query.queryText,
3132
},
3233
databases: submission.databases,
3334
}, response);
@@ -51,11 +52,7 @@ export function processUpdatedVariantAnalysis(
5152
const variantAnalysis: VariantAnalysis = {
5253
id: response.id,
5354
controllerRepoId: response.controller_repo.id,
54-
query: {
55-
name: previousVariantAnalysis.query.name,
56-
filePath: previousVariantAnalysis.query.filePath,
57-
language: previousVariantAnalysis.query.language
58-
},
55+
query: previousVariantAnalysis.query,
5956
databases: previousVariantAnalysis.databases,
6057
status: processApiStatus(response.status),
6158
actionsWorkflowRunId: response.actions_workflow_run_id,

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisAnalyzedRepos.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ describe(VariantAnalysisAnalyzedRepos.name, () => {
1717
name: 'Example query',
1818
filePath: 'example.ql',
1919
language: VariantAnalysisQueryLanguage.Javascript,
20+
queryText: 'import javascript\nselect 1',
2021
},
2122
databases: {},
2223
status: VariantAnalysisStatus.InProgress,

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisOutcomePanels.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe(VariantAnalysisOutcomePanels.name, () => {
1616
name: 'Example query',
1717
filePath: 'example.ql',
1818
language: VariantAnalysisQueryLanguage.Javascript,
19+
queryText: 'import javascript\nselect 1',
1920
},
2021
databases: {},
2122
status: VariantAnalysisStatus.InProgress,

extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-processor.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ describe('Variant Analysis processor', function() {
3131
'filePath': 'query-file-path',
3232
'language': VariantAnalysisQueryLanguage.Javascript,
3333
'name': 'query-name',
34+
'queryText': mockSubmission.query.queryText,
3435
},
3536
'databases': {
3637
'repositories': ['1', '2', '3'],

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis-submission.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export function createMockSubmission(): VariantAnalysisSubmission {
1010
name: 'query-name',
1111
filePath: 'query-file-path',
1212
language: VariantAnalysisQueryLanguage.Javascript,
13+
queryText: 'query-text',
1314
pack: 'base64-encoded-string',
1415
},
1516
databases: {

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ export function createMockVariantAnalysis(
2020
query: {
2121
name: 'a-query-name',
2222
filePath: 'a-query-file-path',
23-
language: VariantAnalysisQueryLanguage.Javascript
23+
language: VariantAnalysisQueryLanguage.Javascript,
24+
queryText: 'a-query-text',
2425
},
2526
databases: {
2627
repositories: ['1', '2', '3'],

0 commit comments

Comments
 (0)