Skip to content

Commit d173ff3

Browse files
Convert vscodeMessageHandler to use useCallback
1 parent da8f959 commit d173ff3

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

extensions/ql-vscode/src/view/results/ResultTables.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,16 @@ export function ResultTables(props: ResultTablesProps) {
145145
}
146146
}, []);
147147

148-
const vscodeMessageHandler = (evt: MessageEvent): void => {
149-
// sanitize origin
150-
const origin = evt.origin.replace(/\n|\r/g, "");
151-
evt.origin === window.origin
152-
? handleMessage(evt.data as IntoResultsViewMsg)
153-
: console.error(`Invalid event origin ${origin}`);
154-
};
148+
const vscodeMessageHandler = useCallback(
149+
(evt: MessageEvent): void => {
150+
// sanitize origin
151+
const origin = evt.origin.replace(/\n|\r/g, "");
152+
evt.origin === window.origin
153+
? handleMessage(evt.data as IntoResultsViewMsg)
154+
: console.error(`Invalid event origin ${origin}`);
155+
},
156+
[handleMessage],
157+
);
155158

156159
// TODO: Duplicated from results.tsx consider a way to
157160
// avoid this duplication

0 commit comments

Comments
 (0)