Skip to content

Commit d18e3dd

Browse files
committed
Fix performance of variant analysis view
When the variant analysis view was being rerendered, we were also reregistering the message listeners, while not deregistering the old ones. This resulted in a loop of message listeners being registered, and the variant analysis being rerendered every time a message was received by one of the listeners. This will ensure that the listener is only registered once to prevent this from happening.
1 parent dc6ae6c commit d18e3dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export function VariantAnalysis({
9090
console.error(`Invalid event origin ${origin}`);
9191
}
9292
});
93-
});
93+
}, []);
9494

9595
if (variantAnalysis?.actionsWorkflowRunId === undefined) {
9696
return <VariantAnalysisLoading />;

0 commit comments

Comments
 (0)