Extract type for modeled method kind (#2835)

Author: charisk

extensions/ql-vscode/src/model-editor/modeled-method.ts

@@ -23,6 +23,8 @@ export interface ModeledMethod extends MethodSignature {
   type: ModeledMethodType;
   input: string;
   output: string;
-  kind: string;
+  kind: ModeledMethodKind;
   provenance: Provenance;
 }
+
+export type ModeledMethodKind = string;

extensions/ql-vscode/src/view/model-editor/KindInput.tsx

@@ -1,14 +1,14 @@
 import * as React from "react";
 import { ChangeEvent, useCallback, useEffect, useMemo } from "react";
-import type { ModeledMethod } from "../../model-editor/modeled-method";
+import type { ModeledMethodKind } from "../../model-editor/modeled-method";
 import { Dropdown } from "../common/Dropdown";
 
 type Props = {
-  kinds: Array<ModeledMethod["kind"]>;
+  kinds: ModeledMethodKind[];
 
-  value: ModeledMethod["kind"] | undefined;
+  value: ModeledMethodKind | undefined;
   disabled?: boolean;
-  onChange: (value: ModeledMethod["kind"]) => void;
+  onChange: (value: ModeledMethodKind) => void;
 
   "aria-label"?: string;
 };
@@ -29,7 +29,7 @@ export const KindInput = ({
     (e: ChangeEvent<HTMLSelectElement>) => {
       const target = e.target as HTMLSelectElement;
 
-      onChange(target.value as ModeledMethod["kind"]);
+      onChange(target.value);
     },
     [onChange],
   );

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

@@ -92,7 +92,7 @@ function ModelableMethodRow(props: MethodRowProps) {
 
       onChange(method, {
         ...modeledMethod,
-        output: target.value as ModeledMethod["output"],
+        output: target.value,
       });
     },
     [onChange, method, modeledMethod],