Skip to content

Commit d402d86

Browse files
committed
Add comment about progress max step
1 parent d9b362d commit d402d86

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,14 @@ export class DataExtensionsEditorView extends AbstractWebview<
197197
return this.cliServer.bqrsDecode(bqrsPath, resultSet.name);
198198
}
199199

200+
/*
201+
* Progress in this class is a bit weird. Most of the progress is based on running the query.
202+
* Query progress is always between 0 and 1000. However, we still have some steps that need
203+
* to be done after the query has finished. Therefore, the maximum step is 1500. This captures
204+
* that there's 1000 steps of the query progress since that takes the most time, and then
205+
* an additional 500 steps for the rest of the work. The progress doesn't need to be 100%
206+
* accurate, so this is just a rough estimate.
207+
*/
200208
private async showProgress(update: ProgressUpdate, maxStep?: number) {
201209
await this.postMessage({
202210
t: "showProgress",

0 commit comments

Comments
 (0)