Skip to content

Commit d4137b2

Browse files
committed
Address comments.
1 parent 12abf81 commit d4137b2

File tree

1 file changed

+26
-25
lines changed

1 file changed

+26
-25
lines changed

extensions/ql-vscode/test/unit-tests/data-extensions-editor/auto-model-v2.test.ts

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,19 @@ describe("createAutoModelV2Request", () => {
8686

8787
describe("getCandidates", () => {
8888
it("doesn't return methods that are already modelled", () => {
89-
const externalApiUsages: ExternalApiUsage[] = [];
90-
externalApiUsages.push({
91-
library: "my.jar",
92-
signature: "org.my.A#x()",
93-
packageName: "org.my",
94-
typeName: "A",
95-
methodName: "x",
96-
methodParameters: "()",
97-
supported: false,
98-
supportedType: "none",
99-
usages: [],
100-
});
89+
const externalApiUsages: ExternalApiUsage[] = [
90+
{
91+
library: "my.jar",
92+
signature: "org.my.A#x()",
93+
packageName: "org.my",
94+
typeName: "A",
95+
methodName: "x",
96+
methodParameters: "()",
97+
supported: false,
98+
supportedType: "none",
99+
usages: [],
100+
},
101+
];
101102
const modeledMethods: Record<string, ModeledMethod> = {
102103
"org.my.A#x()": {
103104
type: "neutral",
@@ -121,18 +122,19 @@ describe("getCandidates", () => {
121122
});
122123

123124
it("doesn't return methods that are supported from other sources", () => {
124-
const externalApiUsages: ExternalApiUsage[] = [];
125-
externalApiUsages.push({
126-
library: "my.jar",
127-
signature: "org.my.A#x()",
128-
packageName: "org.my",
129-
typeName: "A",
130-
methodName: "x",
131-
methodParameters: "()",
132-
supported: true,
133-
supportedType: "none",
134-
usages: [],
135-
});
125+
const externalApiUsages: ExternalApiUsage[] = [
126+
{
127+
library: "my.jar",
128+
signature: "org.my.A#x()",
129+
packageName: "org.my",
130+
typeName: "A",
131+
methodName: "x",
132+
methodParameters: "()",
133+
supported: true,
134+
supportedType: "none",
135+
usages: [],
136+
},
137+
];
136138
const modeledMethods = {};
137139
const candidates = getCandidates(
138140
Mode.Application,
@@ -170,7 +172,6 @@ describe("getCandidates", () => {
170172
externalApiUsages.push({
171173
library: "my.jar",
172174
signature: `org.my.A#x${i}()`,
173-
174175
packageName: "org.my",
175176
typeName: "A",
176177
methodName: `x${i}`,

0 commit comments

Comments
 (0)