Skip to content

Commit d441342

Browse files
Rewrite setInitialState to always set all fields
1 parent a82be42 commit d441342

1 file changed

Lines changed: 19 additions & 23 deletions

File tree

extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class MethodModelingViewProvider extends AbstractWebviewViewProvider<
3838
}
3939

4040
protected override async onWebViewLoaded(): Promise<void> {
41-
await Promise.all([this.setViewState(), this.setInitialState()]);
41+
await this.setInitialState();
4242
this.registerToModelingEvents();
4343
this.registerToModelConfigEvents();
4444
}
@@ -104,29 +104,25 @@ export class MethodModelingViewProvider extends AbstractWebviewViewProvider<
104104
}
105105

106106
private async setInitialState(): Promise<void> {
107-
if (this.modelingStore.hasStateForActiveDb()) {
108-
const selectedMethod = this.modelingStore.getSelectedMethodDetails();
109-
if (selectedMethod) {
110-
this.databaseItem = selectedMethod.databaseItem;
111-
this.language = tryGetQueryLanguage(
112-
selectedMethod.databaseItem.language,
113-
);
114-
this.method = selectedMethod.method;
115-
116-
await this.postMessage({
117-
t: "setSelectedMethod",
118-
method: selectedMethod.method,
119-
modeledMethods: selectedMethod.modeledMethods,
120-
isModified: selectedMethod.isModified,
121-
isInProgress: selectedMethod.isInProgress,
122-
processedByAutoModel: selectedMethod.processedByAutoModel,
123-
});
124-
}
107+
await this.setViewState();
125108

126-
await this.postMessage({
127-
t: "setInModelingMode",
128-
inModelingMode: true,
129-
});
109+
const stateForActiveDb = this.modelingStore.getStateForActiveDb();
110+
if (!stateForActiveDb) {
111+
return;
112+
}
113+
114+
await this.setDatabaseItem(stateForActiveDb.databaseItem);
115+
116+
const selectedMethod = this.modelingStore.getSelectedMethodDetails();
117+
if (selectedMethod) {
118+
await this.setSelectedMethod(
119+
stateForActiveDb.databaseItem,
120+
selectedMethod.method,
121+
selectedMethod.modeledMethods,
122+
selectedMethod.isModified,
123+
selectedMethod.isInProgress,
124+
selectedMethod.processedByAutoModel,
125+
);
130126
}
131127
}
132128

0 commit comments

Comments
 (0)