Skip to content

Commit d8435d1

Browse files
committed
Fix skipIfTrue
Also, update jsdoc for `resolveQlpacks`.
1 parent 6f43530 commit d8435d1

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

extensions/ql-vscode/src/cli.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1138,8 +1138,8 @@ export class CodeQLCliServer implements Disposable {
11381138
/**
11391139
* Gets information about available qlpacks
11401140
* @param additionalPacks A list of directories to search for qlpacks before searching in `searchPath`.
1141-
* @param searchPath A list of directories to search for packs not found in `additionalPacks`. If undefined,
1142-
* the default CLI search path is used.
1141+
* @param extensionPacksOnly Whether to only search for extension packs. If true, only extension packs will
1142+
* be returned. If false, all packs will be returned.
11431143
* @returns A dictionary mapping qlpack name to the directory it comes from
11441144
*/
11451145
async resolveQlpacks(

extensions/ql-vscode/test/vscode-tests/cli.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,9 @@ export function itWithCodeQL() {
4444
}
4545

4646
export async function skipIfTrue(condition: Thenable<boolean>) {
47-
return (await condition) ? beforeEach(() => {}) : beforeEach.skip(() => {});
47+
return beforeEach(async () => {
48+
if (await condition) {
49+
pending();
50+
}
51+
});
4852
}

0 commit comments

Comments
 (0)